Skip to content

Ergodone - Change VID/PID to official values and enable NKRO by default#1801

Closed
yuhe00 wants to merge 3 commits intoqmk:masterfrom
yuhe00:ergodone
Closed

Ergodone - Change VID/PID to official values and enable NKRO by default#1801
yuhe00 wants to merge 3 commits intoqmk:masterfrom
yuhe00:ergodone

Conversation

@yuhe00
Copy link
Contributor

@yuhe00 yuhe00 commented Oct 3, 2017

Thanks to @marcostrauss

marcostrauss and others added 3 commits October 2, 2017 10:02
Changed VID/PID to official values and provided fancy alternative
NKRO option enabled by default using FORCE_NKRO
@fredizzimo
Copy link
Contributor

Do you actually have permission to use those identifiers here? I don't think we can just use manufacurer's identifiers without permission.

@yuhe00
Copy link
Contributor Author

yuhe00 commented Oct 3, 2017

I don't think K.T.E.C will mind, since it's still their product, but you are probably right. Will ask for permission. Closing this for now.

@yuhe00 yuhe00 closed this Oct 3, 2017
@marcostrauss
Copy link
Contributor

@kairyu, @hging, @AdamYoung1234:

Dear K.T.E.C. members, owners of the respective VID-PID combo, is it okay that your VID-PID combo as well as the one 47EC, E60D is used in this repository?

@marcostrauss
Copy link
Contributor

I was told, K.T.E.C. doesn't want the official values to be stored in this repo.

These questions remain:

  • Can 47EC, E60D be used as the default, as it contains the company's name?
  • Can we put a link to http://pid.codes/1209/2328/ in the code, so that everybody who wants to use the official values, can do it by himself?

@jackhumbert
Copy link
Member

Putting a link to the official codes should be fine. As for the defaults, it should probably be some not in use by anything else - it doesn't look like 47EC is currently being used as a vendor ID, but I'd feel better about using our FEED as it's a little clearer that it's a bogus one.

@marcostrauss
Copy link
Contributor

Resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants