Ergodone - Change VID/PID to official values and enable NKRO by default#1801
Ergodone - Change VID/PID to official values and enable NKRO by default#1801yuhe00 wants to merge 3 commits intoqmk:masterfrom
Conversation
Changed VID/PID to official values and provided fancy alternative
NKRO option enabled by default using FORCE_NKRO
|
Do you actually have permission to use those identifiers here? I don't think we can just use manufacurer's identifiers without permission. |
|
I don't think K.T.E.C will mind, since it's still their product, but you are probably right. Will ask for permission. Closing this for now. |
|
@kairyu, @hging, @AdamYoung1234: Dear K.T.E.C. members, owners of the respective VID-PID combo, is it okay that your VID-PID combo as well as the one |
|
I was told, K.T.E.C. doesn't want the official values to be stored in this repo. These questions remain:
|
|
Putting a link to the official codes should be fine. As for the defaults, it should probably be some not in use by anything else - it doesn't look like |
|
Resolved. |
Thanks to @marcostrauss