Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jabberwocky: adjust key positioning in Configurator #13447

Merged
merged 3 commits into from
Jul 5, 2021

Conversation

noroadsleft
Copy link
Member

Description

Fixes overlapping keys in Configurator.

image

cc @nopunin10did (keyboard maintainer)

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Some of the keys were visually overlapping when rendered. Adjusted the key positioning to remove the overlaps.
- fix a broken URL
- rewrite the Bootloader access instructions
- remove trailing whitespace
@noroadsleft noroadsleft merged commit 5d52d01 into qmk:master Jul 5, 2021
@noroadsleft noroadsleft deleted the cf/nopunin10did_jabberwocky branch July 5, 2021 10:07
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Jul 7, 2021
* qmk/develop: (23 commits)
  Use the new ST7565 driver on Ergodox Infinity (qmk#13165)
  Xelus Ninjin: rename LAYOUT_all to LAYOUT_tkl_ansi_tsangan; add info.json (qmk#13477)
  Kopibeng XT65: Layout Macro Refactor (qmk#13476)
  [Keyboard] Add poker87c and poker87d (qmk#12810)
  [Keyboard] Add new Elise, 65% Keyboard ANSI / ISO  (qmk#12782)
  [Keyboard] Add bm65iso (qmk#13400)
  [Keyboard] Add keyboard reviung5 (qmk#13375)
  [Keyboard] Add kabedon98e (qmk#13314)
  [Keyboard] Set reasonable defaults for Corne keyboard (qmk#13440)
  /bin/bash to /usr/bin/env bash (qmk#13422)
  Update `MSG_PYTHON_MISSING` (qmk#13427)
  core: chibios: bootloader: use integer pointers as volatile (qmk#13450)
  Migrate SHIFT_ESC and RGB `fn_actions` to Grave Escape and RGB keycodes (qmk#13360)
  `keymap_extras`: Remove deprecated defines (qmk#12949)
  [Keyboard] fix encoder_update_user for nullbitsco/nibble (qmk#13451)
  Traveller cleanup (qmk#13441)
  LatinPadBLE: correct info.json data (qmk#13452)
  Jabberwocky: adjust key positioning in Configurator (qmk#13447)
  Molecule: Layout Macro Refactor (qmk#13453)
  [Docs] added list of MIDI keycodes (qmk#13159)
  ...
jakeprime pushed a commit to jakeprime/qmk_firmware that referenced this pull request Jul 10, 2021
* adjust key positioning in Configurator

Some of the keys were visually overlapping when rendered. Adjusted the key positioning to remove the overlaps.

* update readme.md

- fix a broken URL
- rewrite the Bootloader access instructions
- remove trailing whitespace
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
* adjust key positioning in Configurator

Some of the keys were visually overlapping when rendered. Adjusted the key positioning to remove the overlaps.

* update readme.md

- fix a broken URL
- rewrite the Bootloader access instructions
- remove trailing whitespace
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
* adjust key positioning in Configurator

Some of the keys were visually overlapping when rendered. Adjusted the key positioning to remove the overlaps.

* update readme.md

- fix a broken URL
- rewrite the Bootloader access instructions
- remove trailing whitespace
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
* adjust key positioning in Configurator

Some of the keys were visually overlapping when rendered. Adjusted the key positioning to remove the overlaps.

* update readme.md

- fix a broken URL
- rewrite the Bootloader access instructions
- remove trailing whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants