Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keymap_extras: Remove deprecated defines #12949

Merged
merged 2 commits into from
Jul 5, 2021

Conversation

fauxpark
Copy link
Member

Description

The time has come...

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark force-pushed the keymap-extras-remove-deprecated branch from 421d79c to 03af82d Compare May 30, 2021 09:30
@fauxpark
Copy link
Member Author

Bump

Copy link
Member

@Erovia Erovia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Although we should probably at least ping the affected users.

@Erovia Erovia requested a review from a team June 20, 2021 11:38
@fauxpark
Copy link
Member Author

I would but...that list is way too long.

@Erovia
Copy link
Member

Erovia commented Jun 21, 2021

Yeah, I know, hence the approval and "probably".

In any case, at some point we will need to rip the band-aid off, so might as well do it now.

@tzarc tzarc merged commit 50d4dfd into qmk:develop Jul 5, 2021
@fauxpark fauxpark deleted the keymap-extras-remove-deprecated branch July 6, 2021 00:50
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Jul 7, 2021
* qmk/develop: (23 commits)
  Use the new ST7565 driver on Ergodox Infinity (qmk#13165)
  Xelus Ninjin: rename LAYOUT_all to LAYOUT_tkl_ansi_tsangan; add info.json (qmk#13477)
  Kopibeng XT65: Layout Macro Refactor (qmk#13476)
  [Keyboard] Add poker87c and poker87d (qmk#12810)
  [Keyboard] Add new Elise, 65% Keyboard ANSI / ISO  (qmk#12782)
  [Keyboard] Add bm65iso (qmk#13400)
  [Keyboard] Add keyboard reviung5 (qmk#13375)
  [Keyboard] Add kabedon98e (qmk#13314)
  [Keyboard] Set reasonable defaults for Corne keyboard (qmk#13440)
  /bin/bash to /usr/bin/env bash (qmk#13422)
  Update `MSG_PYTHON_MISSING` (qmk#13427)
  core: chibios: bootloader: use integer pointers as volatile (qmk#13450)
  Migrate SHIFT_ESC and RGB `fn_actions` to Grave Escape and RGB keycodes (qmk#13360)
  `keymap_extras`: Remove deprecated defines (qmk#12949)
  [Keyboard] fix encoder_update_user for nullbitsco/nibble (qmk#13451)
  Traveller cleanup (qmk#13441)
  LatinPadBLE: correct info.json data (qmk#13452)
  Jabberwocky: adjust key positioning in Configurator (qmk#13447)
  Molecule: Layout Macro Refactor (qmk#13453)
  [Docs] added list of MIDI keycodes (qmk#13159)
  ...
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
sroccaserra added a commit to sroccaserra/keyboard that referenced this pull request Jan 7, 2022
sroccaserra added a commit to sroccaserra/keyboard that referenced this pull request Jan 7, 2022
sroccaserra added a commit to sroccaserra/keyboard that referenced this pull request Jan 13, 2022
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants