Repository navigation
test: generate golden exports inside installed artifacts - #101
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (5)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe desktop app now runs a packaged export proof when given its proof argument. The proof checks cancellation behavior, exports five formats, and verifies durable receipts. Tests validate the proof and its generated artifacts. The compatibility documentation describes the installed proof journey and its limits. ChangesPackaged export proof
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Other Sequence Diagram(s)sequenceDiagram
participant ElectronStartup
participant runPackagedExportProof
participant BundledPublicationService
participant ProjectLibrary
ElectronStartup->>runPackagedExportProof: Pass user-data path
runPackagedExportProof->>ProjectLibrary: Check fixture and cancellation state
runPackagedExportProof->>BundledPublicationService: Export five formats to fixed targets
runPackagedExportProof->>ProjectLibrary: Reopen library and verify receipts
runPackagedExportProof-->>ElectronStartup: Return proof report
Merge Risk: ⚪ Minimal · up to No merge-blocking issue was established. Complete the pending native CI run before claiming installed-export evidence. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
The installed export test previously reopened Receipts generated by the host checkout, so it did not exercise the ZIP executable’s bundled export code or fonts. The explicit export proof now runs the production publication service inside the installed executable with fixed synthetic-fixture targets, then a normal installed launch reopens the results through named IPC and renderer controls.
The journey checks picker cancellation without a new revision/Receipt, canonical JSON, golden ChordPro and LRC, the deterministic PDF hash and embedded fonts/tags, archive machine-local authority stripping, durable output hashes and loss reports, and private-marker exclusion from compatibility outputs and diagnostics. Both application launches use an OS-only environment. Fixed targets remain outside protected user data and an existing output directory is refused.
Validation: 27 targeted service/projection/archive tests passed; types, lint, format, contract schemas, main build and discovery of all 23 packaged tests passed. Native installed execution is GitHub CI only and remains pending. Fixed targets do not establish native Save-dialog, consumer-installation or screen-reader acceptance.
Refs #40, #36.
Summary by CodeRabbit