Skip to content

fix(ida): replace __getattribute__ with __getattr__#1231

Merged
xwings merged 1 commit intoqilingframework:devfrom
chinggg:fix-ida-getattr
Sep 24, 2022
Merged

fix(ida): replace __getattribute__ with __getattr__#1231
xwings merged 1 commit intoqilingframework:devfrom
chinggg:fix-ida-getattr

Conversation

@chinggg
Copy link
Contributor

@chinggg chinggg commented Sep 23, 2022

QlRegisterManager overrides getattr but not getattribute, which causes AttributeError

Checklist

Which kind of PR do you create?

  • This PR only contains minor fixes.
  • This PR contains major feature update.
  • This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • The new code conforms to Qiling Framework naming convention.
  • The imports are arranged properly.
  • Essential comments are added.
  • The reference of the new code is pointed out.

Extra tests?

  • No extra tests are needed for this PR.
  • I have added enough tests for this PR.
  • Tests will be added after some discussion and review.

Changelog?

  • This PR doesn't need to update Changelog.
  • Changelog will be updated after some proper review.
  • Changelog has been updated in my PR.

Target branch?

  • The target branch is dev branch.

One last thing


QlRegisterManager overrides __getattr__ but not __getattribute__,
which causes AttributeError
@xwings xwings merged commit 28c06fc into qilingframework:dev Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants