Fix #3230

[charles-cowart]

Status change emails now more informative

[coveralls]

coverage: 92.928% (+0.004%) from 92.924%
when pulling fc29c98 on charles-cowart:email_status_upgrade_v2
into bda13f8 on qiita-spots:dev.

[charles-cowart]

No existing tests on email generation to speak of. Jobs in testing appear to be Processing Jobs type. As discussed we may consider this upgrade w/out tests.

[antgonza]

@charles-cowart, I like the new _notify_updated_status and code looks good. However, after your changes, I think _notify_updated_status could become something like _generate_notification_message that will return a subject/message strings and if empty nothing will be sent via email (while if they are not empty an email will be sent). This separation will allow to test the subject/message generation; what do you think?

[charles-cowart]

@antgonza I think it sounds good, although we still have an issue with simulating the jobs objects themselves. I can work on that for a test.

[antgonza]

I think (at minimum) you can use Artifact(1)._generate_notification_message and Artifact(8)._generate_notification_message

[antgonza]

Some minor comments.

[antgonza]

BTW you need to pull from dev as the error you are finding has already fixed in that version.