Skip to content

Conversation

@charles-cowart
Copy link
Contributor

No description provided.

This will make it easier to track back to individual artifacts.
When an artifact is deleted, files associated with the artifact are
moved from a location associated with the artifact back into the study
uploads folder. The following two files:
    'qtp-sequencing-validate-data.csv'
    'feature-table.qza'
should be deleted instead.
@charles-cowart
Copy link
Contributor Author

@antgonza includes changes from the other PR. I believe they will disappear when the other PR is merged into dev branch?

@coveralls
Copy link

coveralls commented Jan 28, 2023

Coverage Status

coverage: 92.887% (-0.03%) from 92.916%
when pulling 9d4a7c4 on charles-cowart:email_status_upgrade
into 16f415c on qiita-spots:dev.

@antgonza
Copy link
Member

That's correct but this and the other issue (AFAIK) do not touch the same files so, IMOO, it's better to keep them separate by starting both with a clean dev env; hopefully next time.

@antgonza
Copy link
Member

@charles-cowart, note that as there were changes in the del_artifact_fix_v2 branch and as this one was based on that, it now reports conflicts. In the future, if 2 PRs are not based on each other (or touching the same files), IMOO it's better to not based them on each other.

Anyway, can you fix conflicts here or open a new clean PR?

Thank you.


# generate message line
input_artifacts = self.input_artifacts()
if input_artifacts is None:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider revising. not sure if None is a good condition to test against.

@charles-cowart
Copy link
Contributor Author

Closing. Superseded by #3230

@charles-cowart charles-cowart deleted the email_status_upgrade branch January 31, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants