Skip to content

Partial #2237 #2368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 23, 2017
Merged

Partial #2237 #2368

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cc97e89
fix calls to system_call and ebi submissions
antgonza Oct 12, 2017
292e193
fixing errors
antgonza Oct 12, 2017
6a553f6
fix if state == submitting:
antgonza Oct 12, 2017
f27c230
just raise error
antgonza Oct 12, 2017
d721f85
EBISubmissionError -> ComputeError
antgonza Oct 12, 2017
9e10d9c
Merge pull request #2345 from biocore/fix-ebi-1012
josenavas Oct 14, 2017
691ba3d
Fixing merge conflicts
josenavas Oct 20, 2017
259cbe3
Merge branch 'dev' of https://github.com/biocore/qiita into dev
josenavas Oct 20, 2017
bb0772f
Sorting values
josenavas Oct 20, 2017
4feaf8a
Merge branch 'dev' of https://github.com/biocore/qiita into partial-2237
josenavas Oct 20, 2017
55331a9
Case insensitive sorting
josenavas Oct 20, 2017
9fb4d33
Addressing @ElDeveloper's comments
josenavas Oct 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Case insensitive sorting
  • Loading branch information
@josenavas
josenavas committed Oct 20, 2017
commit 55331a93a69b59f5aa5e225a071119545a8c70a9
10 changes: 5 additions & 5 deletions qiita_pet/templates/artifact_ajax/processing_artifact.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@
}
}

options.sort();
options.sort(function(a, b){return a[0].localeCompare(b[0], 'en', {'sensitivity': 'base'});});
$.each(options, function(idx, val) {
$inp.append($("<option>").attr('value', val[0]).text(val[1]));
});
Expand Down Expand Up @@ -326,7 +326,7 @@
.done(function(data){
// Put first the required parameters
$("#cmd-opts-div").append($('<h4>').text('Required parameters:'));
var keys = Object.keys(data.req_options).sort();
var keys = Object.keys(data.req_options).sort(function(a, b){return a.localeCompare(b, 'en', {'sensitivity': 'base'});});
for (var i = 0; i < keys.length; i++) {
var key = keys[i];
load_parameter_gui(key, data.req_options[key], sel_artifacts_info, $("#cmd-opts-div"));
Expand All @@ -340,7 +340,7 @@
var sel = $('<select>').appendTo($colDiv).attr('id', 'params-sel').attr('name', 'params-sel').addClass('form-control').attr('placeholder', 'Choose parameter set...');
sel.append($("<option>").attr('value', "").text("Choose parameter set...").prop('disabled', true).prop('selected', true));
var options = data.options;
options.sort(function(a, b) {return (a.name > b.name) ? 1 : ((b.name > a.name) ? -1 : 0);} );
options.sort(function(a, b) {return a.name.localeCompare(b.name, 'en', {'sensitivity': 'base'});} );
for(var i=0; i<options.length; i++) {
sel.append($("<option>").attr('value', options[i].id).attr('data-vals', JSON.stringify(options[i].values)).text(options[i].name));
}
Expand All @@ -355,7 +355,7 @@
}
// Get the parameter set values that the user selected
var opt_vals = JSON.parse($("#params-sel option[value='" + v + "']").attr("data-vals"));
var keys = Object.keys(data.opt_options).sort();
var keys = Object.keys(data.opt_options).sort(function(a, b){return a.localeCompare(b, 'en', {'sensitivity': 'base'});});
for (var i = 0; i < keys.length; i++) {
var key = keys[i];
load_parameter_gui(key, data.opt_options[key], sel_artifacts_info, $("#opt-vals-div"), opt_vals[key], is_analysis_pipeline);
Expand Down Expand Up @@ -411,7 +411,7 @@
var sel = $('<select>').appendTo($colDiv).attr('id', 'command-sel').attr('name', 'command').addClass('form-control').attr('placeholder', 'Choose command...');
sel.append($("<option>").attr('value', "").text("Choose command...").prop('disabled', true).prop('selected', true));
var commands = data.commands;
commands.sort(function(a, b) {return (a.command > b.command) ? 1 : ((b.command > a.command) ? -1 : 0);} );
commands.sort(function(a, b) {return a.command.localeCompare(b.command, 'en', {'sensitivity': 'base'});} );
for(var i=0; i<commands.length; i++) {
if (commands[i].output.length != 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use !==

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

sel.append($("<option>").attr('value', commands[i].id).text(commands[i].command));
Expand Down