Jobs list as modal #2289
Merged
Jobs list as modal #2289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With some recent changes to the position of the navigation bar, the header of the jobs list is cut from screen. With this patch in place, the jobs list will be shown as a modal window, so that won't be a problem anymore.
…iita into jobs-list-as-modal
Codecov Report
@@ Coverage Diff @@
## dev #2289 +/- ##
=======================================
Coverage 93.84% 93.84%
=======================================
Files 163 163
Lines 18494 18494
=======================================
Hits 17356 17356
Misses 1138 1138Continue to review full report at Codecov.
|
josenavas
approved these changes
Sep 15, 2017
|
Thanks for finalizing this @antgonza! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ElDeveloper asked me to fix and issue a new PR. The problem was that we now need to check if the modal is being shown to update the information.