ENH: Make jobs list modal #2273
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With some recent changes to the position of the navigation bar, the header of the jobs list is cut from screen. With this patch in place, the jobs list will be shown as a modal window, so that won't be a problem anymore.
Codecov Report
@@ Coverage Diff @@
## remove-moi #2273 +/- ##
===========================================
Coverage 93.78% 93.78%
===========================================
Files 161 161
Lines 18249 18249
===========================================
Hits 17115 17115
Misses 1134 1134Continue to review full report at Codecov.
|
|
Looks better now that it actually works:
|
|
Note that this PR is not ready to be merged, for some reason, the jobs are not being automatically updated once the modal is open. @ElDeveloper, do you think you could take a look before the end of the day 09/17/17? Thanks! |
|
superseded by #2289 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some recent changes to the position of the navigation bar, the
header of the jobs list is cut from screen. With this patch in place,
the jobs list will be shown as a modal window, so that won't be a
problem anymore.
Problem:
Proposed solution:
I have not been able to fully test this, as I can't figure out an easy way to add jobs to my installation. Is there an easy way to test this? Maybe in the development environment?