Refactoring the refactor (II): Add artifact creation page #1680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tudy-pages-artifact-creation
… into artifact-study-pages-artifact-creation
|
This is ready for review |
| User adding the atrifact | ||
| filepaths : dict of {str: [str, ...], ...} | ||
| List of files to attach to the artifact, keyed to the file type | ||
| filepaths : dict of {str: str} |
There was a problem hiding this comment.
Not sure the description and the example match.
There was a problem hiding this comment.
Good catch - done
|
Some comments. |
| User adding the atrifact | ||
| filepaths : dict of {str: [str, ...], ...} | ||
| List of files to attach to the artifact, keyed to the file type | ||
| filepaths : str |
There was a problem hiding this comment.
This description doesn't match "my inferred type", it seems like it really is a dictionary, not a string, am I missing something?
|
Just a few comments. |
|
👍 @ElDeveloper can you merge? |
ElDeveloper
added a commit
that referenced
this pull request
Mar 14, 2016
…-creation Refactoring the refactor (II): Add artifact creation page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #1679, so review/merge that one first
This PR adds the page and code needed for adding an artifact to the system. At this point, this page is not integrated with the rest of the system in order to keep the PR small. It will be integrated in the next PR, which I'm almost done.
The tests, however, should pass.
The previous implementation was buggy and it did not allow to upload an artifact with more than a single lane or if it was missing the reverse reads. The user feedback has been also improved by performing the files checks on the fly rather when it clicks the create button.