Refactoring the refactor (I): Fix prep info creation #1679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into artifact-study-pages-fix-prep-creation
… into artifact-study-pages-fix-prep-creation
| Returns | ||
| ------- | ||
| (list of str, list of str, dict of {str: list of str}) | ||
| The list of txt,csv files in the upload dir for the given study |
There was a problem hiding this comment.
Yeah, same comment, plus txt,csv -> txt, csv
There was a problem hiding this comment.
I think this is actually a typo in the documentation. We are supporting tsv (Tab Separated Values) rather than csv (Comma Separated Values).
|
One minor comment, then 👍 @squirrelo or @ElDeveloper could you review? |
|
|
||
|
|
||
| def new_prep_template_get_req(study_id): | ||
| """ |
There was a problem hiding this comment.
Can you add a description to this function?
|
👍 Just a few comments, looking good overall! |
|
Comments addressed |
|
👍 |
antgonza
added a commit
that referenced
this pull request
Mar 10, 2016
…-creation Refactoring the refactor (I): Fix prep info creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous implementation, the addition of the prep info and the first artifact was forced to occur at the same point. We used that strategy at the beginning of Qiita and we changed it later because that did not follow the workflow.
At the same time, if the artifact creation fail for whatever reason, the entire page was broke and the user was not able to see the study page again.
Here, the addition of the artifact is removed from the addition of the prep information.
At this point, artifacts can't be added, but that will be added in the next PR, to keep them small.
Thus, the interface is broken at this point BUT the tests should pass.