Fix inconsistency on failure updating #1054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One small comment. |
Merged
…consistency-on-failure-updating
| value_type = type(value).__name__ | ||
|
|
||
| if column_type != value_type: | ||
| if "invalid input syntax for" in str(e): |
There was a problem hiding this comment.
Something like this from search.py would probably be cleaner, since it directly connects the python datatype to the SQL datatype and the invalid syntax could be for other reasons besides type.
|
One comment. |
|
This should be ready for final review/merge! |
|
ping @biocore/qiita-dev |
| def __setitem__(self, column, value): | ||
| r"""Sets the metadata value for the category `column` | ||
| def add_setitem_queries(self, column, value, conn_handler, queue): | ||
| """Adds the SQL queries needed to set and item to the queue |
There was a problem hiding this comment.
Can you rephrase this docstring, I don't think it makes sense.
|
Looks good, but I think this might be missing some tests? |
|
Thanks @ElDeveloper |
|
Thanks @josenavas! |
ElDeveloper
added a commit
that referenced
this pull request
Apr 13, 2015
…updating Fix inconsistency on failure updating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #1050, review and merge that one first.Main motivation of the PR: the
update_categoryfunction can leave the DB in an inconsistent state because the updates to the samples are done independently, so if one fails, the previous ones are already modified. By moving the__setitem__queries to a function that adds them to a queue, we can use that function inupdate_categoryto perform everything in a single transaction block.Also, in a previous PR, @squirrelo commented that the way types in the error were checked was probably not correct (for some reason I received that notification from github today). I tested it and @squirrelo was right, so I fixed it here. It is less elegant, but at least is correct.