Unify update category #1050
Merged
Unify update category #1050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 57ab913 on josenavas:unify-update-category into * on biocore:master*. |
|
👍 |
…update-category
|
Now that #1044 has been merged, this should be faster to review! |
|
|
||
| for k, v in viewitems(samples_and_values): | ||
| sample = self[k] | ||
| sample[category] = v |
There was a problem hiding this comment.
why not do self[k][category] = v and not need to instantiate sample.
There was a problem hiding this comment.
You're not saving the instantiation, it is happening at the moment that you do self[k]. Anyways, this is left like this because I modify this in my other PR #1054....
|
One small comment. |
|
Thanks @squirrelo I just answered it, if you think that's ok, it is mergeable! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the
update_categoryfunction to the base class. This PR includes the commits in #1044 so review/merge that one first.I just moved the code around and created the tests for the prep template class.