Removing the remove_category function #1047
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think the
remove_category
function is needed, so I'm removing it from the code base.The reasons why I think this function should be removed:
Since it is clear that a lot of though has to be put in this function, I think it is safer to just remove it for now and put it back once the functionality is needed and we actually have a design for all the mechanisms to notify users once a template has been changed in this way. Note that IMOO, adding new columns is not a big deal, however, removing columns is another story.