Skip to content

Commit b0358b9

Browse files
committed
Merge pull request #1047 from josenavas/drop-remove-category
Removing the remove_category function
2 parents 2199bdd + eeeef3d commit b0358b9

File tree

2 files changed

+0
-38
lines changed

2 files changed

+0
-38
lines changed

qiita_db/metadata_template/sample_template.py

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -481,32 +481,6 @@ def update(self, md_template):
481481
if '_qiime_' not in basename(fp):
482482
pt.create_qiime_mapping_file(fp)
483483

484-
def remove_category(self, category):
485-
"""Remove a category from the sample template
486-
487-
Parameters
488-
----------
489-
category : str
490-
The category to remove
491-
492-
Raises
493-
------
494-
QiitaDBColumnError
495-
If the column does not exist in the table
496-
"""
497-
table_name = self._table_name(self.study_id)
498-
conn_handler = SQLConnectionHandler()
499-
500-
if category not in self.categories():
501-
raise QiitaDBColumnError("Column %s does not exist in %s" %
502-
(category, table_name))
503-
504-
# This operation may invalidate another user's perspective on the
505-
# table
506-
conn_handler.execute("""
507-
ALTER TABLE qiita.{0} DROP COLUMN {1}""".format(table_name,
508-
category))
509-
510484
def update_category(self, category, samples_and_values):
511485
"""Update an existing column
512486

qiita_db/metadata_template/test/test_sample_template.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1237,18 +1237,6 @@ def test_add_category(self):
12371237
obs = {k: v['new_column'] for k, v in self.tester.items()}
12381238
self.assertEqual(obs, exp)
12391239

1240-
def test_remove_category(self):
1241-
with self.assertRaises(QiitaDBColumnError):
1242-
self.tester.remove_category('does not exist')
1243-
1244-
for v in self.tester.values():
1245-
self.assertIn('elevation', v)
1246-
1247-
self.tester.remove_category('elevation')
1248-
1249-
for v in self.tester.values():
1250-
self.assertNotIn('elevation', v)
1251-
12521240
def test_to_file(self):
12531241
"""to file writes a tab delimited file with all the metadata"""
12541242
fd, fp = mkstemp()

0 commit comments

Comments
 (0)