Moving setitem to the base class #1044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.tester['column that does not exist'] = 0.3 | ||
| self.assertEqual(self.tester['center_name'], 'ANL') | ||
| self.tester['center_name'] = "FOO" | ||
| self.assertEqual(self.tester['center_name'], "FOO") |
There was a problem hiding this comment.
This also needs a test for when a column has the wrong datatype, triggering the ValueError.
There was a problem hiding this comment.
This is a great point! When I wrote the test I noticed that there is a "bug" on the code (it is just preventing a useful message, therefore quoted). I'm fixing it right now.
|
Couple comments. |
| """, (column,))[0] | ||
| value_type = type(value).__name__ | ||
|
|
||
| if column_type != value_type: |
There was a problem hiding this comment.
This seems to be comparing SQL types (column_type) and python type (value_type). Is that kosher?
Merged
|
Changes Unknown when pulling 380057e on josenavas:unify-sample-setitem into * on biocore:master*. |
|
💥 ready for another round of review! |
|
👍 |
ElDeveloper
added a commit
that referenced
this pull request
Apr 9, 2015
Moving setitem to the base class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just move the code to the base class and updated the SQL to make use of the class variables to fill the sql correctly.