Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix grandpa time #1346

Merged
merged 3 commits into from
Sep 22, 2022
Merged

fix grandpa time #1346

merged 3 commits into from
Sep 22, 2022

Conversation

turuslan
Copy link
Contributor

Referenced issues

Description of the Change

  • update const
  • fix difference sign

Benefits

Fix finalization.

Possible Drawbacks

Usage Examples or Tests

Alternate Designs

Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Copy link
Contributor

@igor-egorov igor-egorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #1346 (cb91b14) into master (c48739c) will increase coverage by 0.01%.
The diff coverage is 45.00%.

❗ Current head cb91b14 differs from pull request most recent head 48a5e96. Consider uploading reports for the commit 48a5e96 to get more accurate results

@@            Coverage Diff             @@
##           master    #1346      +/-   ##
==========================================
+ Coverage   24.38%   24.40%   +0.01%     
==========================================
  Files         619      619              
  Lines       23021    23036      +15     
  Branches    12011    12019       +8     
==========================================
+ Hits         5614     5621       +7     
- Misses      12225    12226       +1     
- Partials     5182     5189       +7     
Impacted Files Coverage Δ
core/consensus/babe/impl/babe_impl.cpp 14.02% <0.00%> (-0.03%) ⬇️
core/consensus/grandpa/impl/grandpa_impl.hpp 100.00% <ø> (ø)
core/consensus/grandpa/impl/voting_round_impl.cpp 24.05% <0.00%> (ø)
core/injector/application_injector.cpp 32.12% <ø> (ø)
core/consensus/grandpa/impl/grandpa_impl.cpp 3.05% <50.00%> (+0.40%) ⬆️
core/application/chain_spec.hpp 63.63% <60.00%> (-36.37%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan merged commit 60e9e2d into master Sep 22, 2022
@turuslan turuslan deleted the fix/grandpa-time branch September 22, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants