This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Double grandpa gossip duration for Kusama and test networks #5448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it won't get triggered by additional grandpa delay.
(and Westend as it is meant to be a testbed for Polkadot)
eskimor
changed the title
Double grandpa gossip duration - for now just as a test on Versi
Double grandpa gossip duration for Kusama and test networks
May 9, 2022
eskimor
added
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit.
labels
May 10, 2022
sandreim
approved these changes
May 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sandreim
reviewed
May 10, 2022
ordian
approved these changes
May 10, 2022
bot merge |
Waiting for commit status. |
eskimor
added a commit
that referenced
this pull request
Jun 2, 2022
* Double grandpa gossip duration. * Make resend period slightly larger. So it won't get triggered by additional grandpa delay. * Bump other values as well. * Don't change gossip duration on Polkadot. (and Westend as it is meant to be a testbed for Polkadot)
ordian
added
the
T5-parachains_protocol
This PR/Issue is related to Parachains features and protocol changes.
label
Aug 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit.
T5-parachains_protocol
This PR/Issue is related to Parachains features and protocol changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: paritytech/polkadot-sdk#830 ... this will reduce load on nodes in exchange for slightly slower finality. We would like to see the effect this has on Kusama.