Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Double grandpa gossip duration for Kusama and test networks #5448

Merged
merged 4 commits into from
May 10, 2022

Conversation

eskimor
Copy link
Member

@eskimor eskimor commented May 4, 2022

See: paritytech/polkadot-sdk#830 ... this will reduce load on nodes in exchange for slightly slower finality. We would like to see the effect this has on Kusama.

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label May 4, 2022
So it won't get triggered by additional grandpa delay.
(and Westend as it is meant to be a testbed for Polkadot)
@eskimor eskimor requested a review from rphmeier May 9, 2022 12:26
@eskimor eskimor changed the title Double grandpa gossip duration - for now just as a test on Versi Double grandpa gossip duration for Kusama and test networks May 9, 2022
@eskimor eskimor added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels May 10, 2022
Copy link
Contributor

@sandreim sandreim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ordian
Copy link
Member

ordian commented May 10, 2022

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 4aea246 into master May 10, 2022
@paritytech-processbot paritytech-processbot bot deleted the rk-half-grandpa-gossip branch May 10, 2022 12:48
eskimor added a commit that referenced this pull request Jun 2, 2022
* Double grandpa gossip duration.

* Make resend period slightly larger.

So it won't get triggered by additional grandpa delay.

* Bump other values as well.

* Don't change gossip duration on Polkadot.

(and Westend as it is meant to be a testbed for Polkadot)
@ordian ordian added the T5-parachains_protocol This PR/Issue is related to Parachains features and protocol changes. label Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. T5-parachains_protocol This PR/Issue is related to Parachains features and protocol changes.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants