Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename content tab "Size" column to "Total Size" #16526

Merged
merged 1 commit into from
Feb 27, 2022

Conversation

unitmatrix
Copy link
Contributor

This renames the "Size" column title on content tab to "Total Size" and changes the corresponding Enum's ID in the code to match the new title.
Fixes #7348

@Chocobo1
Copy link
Member

Can you also update the WebUI? Should be somewhere in webui/www/private.

@Chocobo1 Chocobo1 added GUI GUI-related issues/changes WebUI WebUI-related issues/changes labels Feb 25, 2022
@glassez
Copy link
Member

glassez commented Feb 25, 2022

Haven't we considered similar changes recently? Last time it ended in nothing...

@unitmatrix
Copy link
Contributor Author

Replicated for WebUI as requested, also rolled back changes for the Enum IDs to make this commit a pure UI update for this issue.

@glassez - considered and agreed to rename it: #7348 (comment)

@xavier2k6
Copy link
Member

Haven't we considered similar changes recently? Last time it ended in nothing...

The most recent PR #14389

Also for reference: #14389 (comment)

Copy link
Member

@glassez glassez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, go ahead with it.

@Chocobo1 Chocobo1 merged commit d2aad3a into qbittorrent:master Feb 27, 2022
@Chocobo1
Copy link
Member

@unitmatrix
Thank you!

@Chocobo1 Chocobo1 added this to the 4.5.0 milestone Feb 27, 2022
@unitmatrix unitmatrix deleted the rename_size_to_total_size branch March 11, 2022 14:46
sledgehammer999 pushed a commit to sledgehammer999/qBittorrent that referenced this pull request Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI GUI-related issues/changes WebUI WebUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content tab: "Size" column should display selected files size or be renamed to "Total Size"
4 participants