Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content tab: "Size" column should display selected files size or be renamed to "Total Size" #7348

Closed
ghost opened this issue Aug 25, 2017 · 9 comments · Fixed by #16526
Closed
Labels
Confirmed bug An issue confirmed by project team to be considered as a bug GUI GUI-related issues/changes

Comments

@ghost
Copy link

ghost commented Aug 25, 2017

Please provide the following information

qBittorrent version and Operating System: qB 3.3.15

What is the problem: [minor] Deselecting a file in the "Content" tab updates the "Remaining" size, but non the "Total". Note: the size is updated inthe main "Transfers" tab.

What is the expected behavior: Should update both.

Steps to reproduce: Select/deselect an item in the torrent Content list.

Extra info(if any):

2017-08-25 20_21_23-qbittorrent v3 3 15

2017-08-25 20_21_02-settings

@xavier2k6
Copy link
Member

xavier2k6 commented Sep 15, 2020

@FranciscoPombal I understand what's going on here & can re-produce in current master build!

The "Size column" in the content tab seems to actually be showing the "Total Size" info! (mislabelled??)

  • that's why the "Size" column in the "Transfer List" is correctly showing the reduction if a file is de-selected & not showing that reduction in the "Size" column of the contents tab.

If you display "Total Size" column in transfer list, you will see it remains the same as "Size column" in the content tab.

total size vs size transfer list

size contents tab

@FranciscoPombal FranciscoPombal added Confirmed bug An issue confirmed by project team to be considered as a bug GUI GUI-related issues/changes labels Sep 15, 2020
@FranciscoPombal FranciscoPombal changed the title Partial torrent size update in "Content" tab. Content tab: "Size" column should display selected files size or be renamed to "Total Size" Sep 15, 2020
@FranciscoPombal
Copy link
Member

@glassez @Chocobo1

What do you think should be done? I vote for renaming this column to "Total Size" and adding an actual "Size" column.

@glassez
Copy link
Member

glassez commented Sep 15, 2020

I don't understand why all this complexity is here... We're talking about files. The file size does not change whether this file is selected or not.

@thalieht
Copy link
Contributor

IMO since this only affects folders, we can't add a whole column just to display the differences for them. An idea is to update the size for folders in the format X / Total GiB if files belonging to them are unselected

@FranciscoPombal
Copy link
Member

@glassez

I don't understand why all this complexity is here... We're talking about files. The file size does not change whether this file is selected or not.

This is only about reporting total sizes of all files/selected files in each folder.

IMO since this only affects folders, we can't add a whole column just to display the differences for them. An idea is to update the size for folders in the format X / Total GiB if files belonging to them are unselected

I like this suggestion even better, I think it's the best one. @glassez ?

@xavier2k6
Copy link
Member

I vote for renaming this column to "Total Size"

This!

adding an actual "Size" column.

Let someone create a new issue to "Feature request" it if they so wish....

@xavier2k6
Copy link
Member

similar to #9922

@xavier2k6
Copy link
Member

I vote for renaming this column to "Total Size"

@zzandland Fancy tackling this too? (Since you'll be working on contents)

ref - #7348 (comment)

@zzandland
Copy link
Contributor

@xavier2k6 Yup I'll see what I can do. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confirmed bug An issue confirmed by project team to be considered as a bug GUI GUI-related issues/changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants