Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump requirement to libtorrent 1.2 #13068

Merged
merged 2 commits into from
Jun 27, 2020
Merged

Bump requirement to libtorrent 1.2 #13068

merged 2 commits into from
Jun 27, 2020

Conversation

Chocobo1
Copy link
Member

Closes #12258.

@Chocobo1 Chocobo1 added the Code cleanup Clean up the code while preserving the same outcome label Jun 26, 2020
@Chocobo1 Chocobo1 added this to the 4.2.6 milestone Jun 26, 2020
@Chocobo1 Chocobo1 force-pushed the libt branch 2 times, most recently from 73a336a to d8665c4 Compare June 26, 2020 01:01
@glassez
Copy link
Member

glassez commented Jun 26, 2020

Well, it's about time...
But I think that since the next version is delayed (it's really annoying), we should release it as v4.3, so these changes will be more appropriate.

@jagannatharjun
Copy link
Member

jagannatharjun commented Jun 26, 2020 •
edited
Loading

we should release it as v4.3, so these changes will be more appropriate.

I think the same, theming support is complete, I think I should do color changes for piece bar and speed graphs too. (what do you think @glassez @Chocobo1 )

@Chocobo1
Copy link
Member Author

I think I should do color changes for piece bar and speed graphs too. (what do you think @glassez @Chocobo1 )

Not sure, however IMO it is not a bad idea to have them customizable.

@Chocobo1 Chocobo1 merged commit ca8654d into qbittorrent:master Jun 27, 2020
@Chocobo1 Chocobo1 deleted the libt branch June 27, 2020 04:52
IceCodeNew pushed a commit to IceCodeNew/qBittorrent-Enhanced-Edition that referenced this pull request Aug 28, 2020
@Chocobo1 @IceCodeNew
Merge pull request qbittorrent#13068 from Chocobo1/libt
5fd4671 
Bump requirement to libtorrent 1.2
@xavier2k6 xavier2k6 mentioned this pull request Sep 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glassez glassez glassez approved these changes

@FranciscoPombal FranciscoPombal FranciscoPombal approved these changes

Assignees
No one assigned
Labels
Code cleanup Clean up the code while preserving the same outcome
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

Remove RC_1_1 support
4 participants
@Chocobo1 @glassez @jagannatharjun @FranciscoPombal