Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RC_1_1 support #12258

Closed
sledgehammer999 opened this issue Mar 24, 2020 · 15 comments · Fixed by #13068
Closed

Remove RC_1_1 support #12258

sledgehammer999 opened this issue Mar 24, 2020 · 15 comments · Fixed by #13068

Comments

@sledgehammer999
Copy link
Member

sledgehammer999 commented Mar 24, 2020

It seems that the transition to RC_1_2 is far smoother than the transitiion to RC_1_1.
Since we provide via the PPA a 1.2.x libtorrent, I don't see any point into continuing to support RC_1_1 in v4_2_x.

So I propose we drop it for the next release.
Do you have any objections?

@Jylijs
Copy link

Jylijs commented Mar 25, 2020

qBittorrent 4.2.0 and 4.2.1 has been banned on some private trackers, due to it has some traffic reporting issues. I guess this may be a bug from libtorrent 1.2 but not qBittorrent, but as most users use qBittorrent 4.2 with libtorrent 1.2, so those trackers just banned qbt 4.2. I'm not sure if such issue still exists on the new qBittorrent 4.2.2 with libtorrent 1.2.5.

@FranciscoPombal
Copy link
Member

qBittorrent 4.2.0 and 4.2.1 has been banned on some private trackers, due to it has some traffic reporting issues. I guess this may be a bug from libtorrent 1.2 but not qBittorrent, but as most users use qBittorrent 4.2 with libtorrent 1.2, so those trackers just banned qbt 4.2. I'm not sure if such issue still exists on the new qBittorrent 4.2.2 with libtorrent 1.2.5.

There is no problem in reported traffic as far as I know (if you know of one and have a way to reproduce it, please post an issue report). qBittorrent 4.2.x has a bunch of connectivity issues, particularly for users using proxies and/or VPNs, so I would expect that to be the reason for the ban.

@ghost
Copy link

ghost commented Mar 25, 2020

I think he’s talking about the trackers which are suffering with double count issue due to announcing to all trackers in a tier bug. It got fixed in latest libtorrent though. Another way they could face double count is due to the multi homed announce in RC1-2

@FranciscoPombal
Copy link
Member

@An0n666

I think he’s talking about the trackers which are suffering with double count issue due to announcing to all trackers in a tier bug. It got fixed in latest libtorrent though. Another way they could face double count is due to the multi homed announce in RC1-2

How would this bug be relevant to private trackers though? Don't all private trackers use private torrents with only 1 announce URL, so that they are able to properly keep tabs of transferred amounts?

@ghost
Copy link

ghost commented Mar 25, 2020

Nope. Some private trackers use multiple trackers for load balancing/as backup. However such trackers usually have measures to prevent double count.
The main issue arises with multi homed announce. When you announce from both IPv4 & IPv6 it becomes difficult to avoid double count unless the tracker is correctly configured to support it.

@FranciscoPombal
Copy link
Member

@An0n666
Ok. Do you happen to know if this bug is fixed for all combinations of enabling/disabling the options "Always announce to all trackers in a tier" and "Always announce to all tiers"?

@ghost
Copy link

ghost commented Mar 25, 2020

@An0n666
Ok. Do you happen to know if this bug is fixed for all combinations of enabling/disabling the options "Always announce to all trackers in a tier" and "Always announce to all tiers"?

Yes that bug is fixed now. However there are still many issues specially in regards to VPN/Proxy users which ultimately led to the ban of qBT 4.2.

@The5kull
Copy link

Nope. Some private trackers use multiple trackers for load balancing/as backup. However such trackers usually have measures to prevent double count.
The main issue arises with multi homed announce. When you announce from both IPv4 & IPv6 it becomes difficult to avoid double count unless the tracker is correctly configured to support it.

This is the problem with a lot of "new" private trackers, the ones you actually want to avoid for their low content.

@Aniverse
Copy link

Forwarded from a private tracker's announcement:

qBittorrent 4.2.x is now whitelisted - posted 14 hours, 33 minutes ago

qBittorrent 4.2.x is now whitelisted, however please note there are many reports of issues with VPN, proxies, networking binding and RSS not working or causing torrents to stall due to lack of connections. Users are expected to deal with these in their own way and we will not provide technical support for these.

Additionally please be advised that version 4.2.1 might incorrectly display working torrents as non-working.

The decision has been made after careful deliberation as most of the issues come from changes in libtorrent 1.2 (RC_1_2). Linux users are advised to remain on libtorrent 1.1 (RC_1_1) for as long as qBittorrent supports it (most likely up to 4.2.3) to avoid these issues.

@ghost
Copy link

ghost commented Mar 28, 2020

Dropping RC_1_1 support before RC_1_2 becomes stable would just prevent existing users from updating to new versions. Nothing good will come out of it. And most private trackers would end up banning 4.2.3+ releases as well. Also there’s no reason to believe that Public tracker users don’t use proxies/VPNs and would still continue to use a broken release.

@FranciscoPombal
Copy link
Member

Dropping RC_1_1 support before RC_1_2 becomes stable would just prevent existing users from updating to new versions. Nothing good will come out of it. And most private trackers would end up banning 4.2.3+ releases as well. Also there’s no reason to believe that Public tracker users don’t use proxies/VPNs and would still continue to use a broken release.

Nobody is saying support needs to be dropped immediately. It can (and should) wait until all major issues with RC_1_2 are ironed out.

@sledgehammer999
Copy link
Member Author

Nobody is saying support needs to be dropped immediately.

Actually that's what I am saying in my opening.

In any case, this probably should be postponed a few releases. Even though, only linux users may benefit from this and custom builders.

@FranciscoPombal
Copy link
Member

Actually that's what I am saying in my opening.

In any case, this probably should be postponed a few releases. Even though, only linux users may benefit from this and custom builders.

Well yeah, when you posted that, "next release" had a different meaning - now it obviously means "next release after emergency release to fix high DPI scaling/RSS not downloading/broken fastresumes on Windows UNC paths, and further releases to iron out RC_1_2 connectivity issues".

@Ryrynz
Copy link

Ryrynz commented Mar 31, 2020

In any case, this probably should be postponed a few releases.
Well yeah, when you posted that, "next release" had a different meaning

Milestone issues aren't linked to appropriate release versions.
Sledge, would you mind pushing out various issues that constantly get put into the next version into 4.30 or even further out? Try to keep the next .1 release issue goals appropriate to what's required now? Things like Map Icons with IDs, Use SQLite to store torrents and fastresumes, Add ability to require an http request to be a POST etc need to be moved out of 4.2.3 milestone issues, probably anything discussed in 2018/2019 shouldn't be in any short term release.

Also, is 4.1.10 still going to still be a thing? Looks like it's on hold indefinitely?

@glassez glassez modified the milestones: 4.2.3, 4.2.4 Apr 4, 2020
@sledgehammer999 sledgehammer999 modified the milestones: 4.2.4, 4.2.5, 4.2.6 Apr 22, 2020
@Seeker2
Copy link

Seeker2 commented Apr 25, 2020

Speaking of missed milestones... how about v3.2.1? #2193

Chocobo1 added a commit to Chocobo1/qBittorrent that referenced this issue Jun 26, 2020
@qbittorrent qbittorrent locked as resolved and limited conversation to collaborators Jun 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants