Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift+Click to select multiple torrents doesn't work #19906

Open
xanatos opened this issue Nov 8, 2023 · 9 comments
Open

Shift+Click to select multiple torrents doesn't work #19906

xanatos opened this issue Nov 8, 2023 · 9 comments

Comments

@xanatos
Copy link

xanatos commented Nov 8, 2023

qBittorrent & operating system versions

qBittorrent 4.6.0 x64
Qt: 6.4.3
Libtorrent: 1.2.19.0
Boost: 1.83.0
OpenSSL: 1.1.1w
zlib: 1.3
OS: Windows 11 Pro 22H2 22621.2215 (10.0.22621)

What is the problem?

Click on one torrent, Shift+Click on another torrent. It doesn't select all the torrents between the first and the clicked torrent. Seems to be a problem of the QT6. On 4.5.5 with QT5 works correctly, 4.5.5 with QT6 doesn't. But with 4.6.0 the QT6 is mandatory. Note that I have more than a hundred paused torrents. On another PC where I have only 5-6 torrents it seems to work correctly.
Selection through keyboard (shift + up/down arrow) work correctly (luckily)

There is another problem with QT6: sometimes the torrent pane begins to scroll left and it doesn't stop until it has scrolled totally to the left.

Steps to reproduce

No response

Additional context

No response

Log(s) & preferences file(s)

No response

@thalieht thalieht added the Can't reproduce Issues that cannot be reproduced label Nov 9, 2023
@xanatos
Copy link
Author

xanatos commented Nov 9, 2023

@thalieht It is the same that is described in this bug: https://bugreports.qt.io/browse/QTBUG-115838 , but I have it on Windows. Tried the

Qt: 6.5.2
Libtorrent: 1.2.19.0
Boost: 1.83.0
OpenSSL: 3.1.4
zlib: 1.3

And it has the same problem.

Multiple selection not always working:

qBittorrent.v5.0.0alpha1.2023-11-09.13-38-33.mp4

Forced scrolling to the left (it seems to be connected to changing the ordering of the listview)

qBittorrent.v5.0.0alpha1.2023-11-09.13-38-16.mp4

@stalkerok
Copy link
Contributor

stalkerok commented Nov 9, 2023

Multiple selection not always working:

You have alpha version 5.0, not 4.6.0
And yes, I confirm, if you click for a long time, it is reproducible.

Forced scrolling to the left (it seems to be connected to changing the ordering of the listview)

Сan't reproduce that.

@xavier2k6
Copy link
Member

xavier2k6 commented Nov 9, 2023

"Multiple selection not always working"

Duplicate of #16818

"Forced scrolling to the left (it seems to be connected to changing the ordering of the listview)"

Appears to be a duplicate of #18992

@xavier2k6 xavier2k6 added Duplicate and removed Can't reproduce Issues that cannot be reproduced labels Nov 9, 2023
@thalieht
Copy link
Contributor

thalieht commented Nov 9, 2023

Are you guys sure you're not holding click and slightly move the mouse when it fails?

@stalkerok
Copy link
Contributor

Are you guys sure you're not holding click and slightly move the mouse when it fails?

hmmm, maybe, but it's not noticeable at all....

@xavier2k6
Copy link
Member

#11768 was with Qt 5.x & it regressed/was re-introduced in Qt6.x........it's becoming less noticable/harder to reproduce in later Qt6 versions like current release of Qt 6.6.0 but it's still there ever so slightly.

@xanatos Do you use a wireless mouse by any chance?

@xanatos
Copy link
Author

xanatos commented Nov 9, 2023

Multiple selection not always working:

You have alpha version 5.0, not 4.6.0 And yes, I confirm, if you click for a long time, it is reproducible.

I have tested in like 20 minutes multiple versions, to test the different versions of QT: 4.5.5 with Qt5 no problem, 4.5.5 with Qt6 problem, 4.6.0 problem, 5.0alpha problem.

@xavier2k6 Yes I do use a wireless mouse, but as I've said, I've tested in 20 minutes 4 versions of qBittorrent, and only the ones with the Qt6 have problems.

I'll add that if I Remote Desktop to the qBittorrent machine, all the problems go away in the Remote Desktop. I had the suspect it was a problem of DPI, but it seems to be set to 100% (that I hope means 96dpi). And both machines are 1920x1080.

@xavier2k6
Copy link
Member

and only the ones with the Qt6 have problems.

Oh I am not disputing that at all & as I've said it was an issue in Qt 5 Series & it was fixed in a newer revision, it then got re-introduced in the Qt 6 Series but it's becoming less & less frequent an issue in the newer revisions of Qt 6 Series.

The reason I asked about the wireless mouse was to possibly see if that plays a role in it......."sensitivity"

@thalieht
Copy link
Contributor

Are you guys sure you're not holding click and slightly move the mouse when it fails?

So... i thoroughly analyzed the 2 gifs from #16818 and in most failures there is a 1-2 pixels mouse movement although there are several failures where it seems completely still although they are crappy 10 fps gifs... entirely possible the mouse was moved and then moved back into position before the next frame was captured.
As for the video in #19906 (comment) it is clear as day that there is mouse movement during all failures.

I did this so you guys will try to reproduce and pay attention to this as it could be important for the Qt devs.

ps. Also for the Qt devs: QAbstractItemView::ExtendedSelection is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants