Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift Select (click) to select a range of torrents does not work (QTBUG-115838) #16818

Open
ackerthehacker2 opened this issue Apr 4, 2022 · 14 comments
Labels
Confirmed bug An issue confirmed by project team to be considered as a bug OS: macOS Issues specific to macOS OS: Windows Issues specific to Windows Qt bugs Bug resides in Qt library Waiting upstream Waiting for changes in dependent libraries

Comments

@ackerthehacker2
Copy link

qBittorrent & operating system versions

qbittorrent 44.2
OS: Mac OS 12.3.1 Intel
Qt 6.2.4
libtorrent 2.0.5

What is the problem?

One cannot use shift click to select a range of file (standard Mac operation).

Command -click works individually
Command-A select all

but if you want to select a range, you are stuck.

Steps to reproduce

On. Mac in qbit. click on TORRENT ...
go down two or more and hold the shift key when you select

Additional context

The is standard Mac UI

Log(s) & preferences file(s)

No response

@thalieht
Copy link
Contributor

thalieht commented Apr 5, 2022

Seems like a regression in Qt6: #11768

@thalieht thalieht added OS: macOS Issues specific to macOS Qt bugs Bug resides in Qt library labels Apr 5, 2022
@ackerthehacker2
Copy link
Author

Yep .. I searched for shift click instead of shift. mouse click ...

@DarkVoyage
Copy link

DarkVoyage commented Apr 19, 2022

It doesn't work sometimes in Windows too after QT6 upgrade. If you select end of range with shift, it selects just the last line instead. You can select range just by dragging with pushed left mouse button over lines. It is not so precise, but might work for some cases. It might help if you push every shift, alt, ctrl at keyboard to remove the effect. Not sure, if it always help, more like a ritual.

@xavier2k6 xavier2k6 added OS: Windows Issues specific to Windows Confirmed bug An issue confirmed by project team to be considered as a bug labels Aug 14, 2022
@xavier2k6
Copy link
Member

@thalieht This seems to be fixed in Qt 6.3.1 (at least on windows)

@DarkVoyage
Can you confirm with below test builld?
https://github.com/xavier2k6/qBittorrent/suites/7792708553/artifacts/328419552

@Kolcha
Copy link
Contributor

Kolcha commented Aug 26, 2022

tested 4.4.2 (based on Qt 6.2.4) and 4.4.4 (based on Qt 6.3.0) official builds on Intel-based and M1-based MacBooks running the same version of macOS (12.5.1) - issue is reproducible only on Intel-based, everything is fine on M1 even with Qt 6.2.4

very strange that Shift + Up/Down arrows works, but not with mouse. in case of mouse it looks like it selects as it should for a moment, but than "single click" event is fired for the last selected item and selection disappears.

this is definitely not a qBittorrent bug, this is something inherited from Qt. also this is another confirmation that macOS for M1 and Intel are different things (since 12.5 difference became is much more noticeable, but previously it also can be found). if summarize in few words: macOS for Intel is something that "just exists" and nothing more, and macOS for Apple Silicon (i.e. M1/M2) is something developed in direction very close to phones rather than computers. degradation...

P.S> I don't have personal MacBook, h/w I used for testing I got from the office due to work responsibilities. and I'll return it very soon.

@DarkVoyage
Copy link

DarkVoyage commented Aug 28, 2022

I've tested 4.4.4 QT 6.3.0 Windows 10 x64. No problem anymore. But it has a little strange behavior, if you still hold SHIFT then click further and keep holding left MB and drag cursor a little in list (up or down) - then you lose selection and it selects just this row or two rows like you don't hold SHIFT at all. But if you still holding SHIFT and click any row again - it will restore previous selection. This dragging is very little, sometimes you click and selection is lost, but it is because it felt small dragging. So not a bug (maybe). There's no (and can't be) such problem with arrow keys, because there's no dragging, just discreet action. So maybe this list dragging has sensitivity in pixels, I think I saw such a setting in some programs.

Also a remark that dragging cursor through rows with LMB while holding shift or ctrl has specific behavior, different to clicking. While ctrl allows adding to selection in any direction and order, shift has effect of canceling some selected items that are outside of range.

@xavier2k6
Copy link
Member

I can no longer seem to reproduce this with the use of Qt 6.5.1

@superbonaci
Copy link

Is there any qBittorrent macOS build with Qt 6.5.1? Mine is 6.4.3.

@luzpaz luzpaz added the Waiting info Waiting for participants to supply more info/fulfill template requirements label Aug 5, 2023
@thalieht
Copy link
Contributor

thalieht commented Aug 5, 2023

Is there any qBittorrent macOS build with Qt 6.5.1?

4.5.3 had Qt 6.5.x https://www.fosshub.com/qBittorrent-old.html

@superbonaci
Copy link

superbonaci commented Aug 5, 2023

I can no longer seem to reproduce this with the use of Qt 6.5.1

@xavier2k6 The issue is still present but doesn't happen always, with qbittorrent-4.5.3_lt20.dmg.
Hold the shift key and keep selecting up and down and eventually it will select only the last one. The first click I'm not holding the Shift key, then all the time.

ezgif-4-34bcdb6ecc

@xavier2k6
Copy link
Member

issue is reproducible only on Intel-based, everything is fine on M1

@superbonaci comment above may still be relevant...

You could also test with the latest master branch which uses Qt 6.5.2 & see if it makes a difference for you.

https://github.com/qbittorrent/qBittorrent/actions/runs/5758594700

@superbonaci
Copy link

https://github.com/qbittorrent/qBittorrent/actions/runs/5758594700

I'm on M1 too.
Testing qBittorrent-CI_macOS_GUI=ON_libtorrent-2.0.9_Qt-6.5.2.zip still same issue. Sometimes select properly and other not, holding shift all the time:

ezgif-4-ad7ebe6489

@glassez
Copy link
Member

glassez commented Aug 7, 2023

@superbonaci
Could you report it to Qt?

@superbonaci
Copy link

@superbonaci Could you report it to Qt?

Done.
https://bugreports.qt.io/browse/QTBUG-115838

@luzpaz luzpaz added Waiting upstream Waiting for changes in dependent libraries and removed Waiting info Waiting for participants to supply more info/fulfill template requirements labels Aug 15, 2023
@xavier2k6 xavier2k6 changed the title Shift Select (click) to select a range of torrents does not work on mac Shift Select (click) to select a range of torrents does not work Sep 27, 2023
@xavier2k6 xavier2k6 changed the title Shift Select (click) to select a range of torrents does not work Shift Select (click) to select a range of torrents does not work (QTBUG-115838) Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confirmed bug An issue confirmed by project team to be considered as a bug OS: macOS Issues specific to macOS OS: Windows Issues specific to Windows Qt bugs Bug resides in Qt library Waiting upstream Waiting for changes in dependent libraries
Projects
None yet
Development

No branches or pull requests

8 participants