add page object e2e tests #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexGalichenko
approved these changes
Oct 30, 2024
CHANGELOG.md
Outdated
| :microscope: - experimental | ||
|
|
||
| ## [unreleased] | ||
| - :pencil: added page object end-to-end tests |
Contributor
There was a problem hiding this comment.
add it to 2.0.0. it will a part of release
|
AlexGalichenko
added a commit
that referenced
this pull request
Dec 4, 2024
* reworked page object approach (#134) * updated dependency to qavajs core (#136) * removed utils (#137) * fixed typings * fixed unit test * updated workflow to run tests on v2 * add page object e2e tests (#139) * add memory processor to playwrightLocator parameter type (#140) --------- Co-authored-by: Alexandr Legchilov <46843062+ALegchilov@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe your changes and any new features you're introducing, or issues you're fixing.
Related Issues
#138