Skip to content

Conversation

@AlexGalichenko
Copy link
Contributor

fixed typings
fixed unit test

Description

Please describe your changes and any new features you're introducing, or issues you're fixing.

  • Updated the CHANGELOG.md.
  • Updated package version in package.json, package-lock.json.
  • Checked that there aren't other open pull requests for the same issue/update.
  • Checked that your contribution follows the project's contribution guidelines.
  • Added corresponding unit/E2E tests
  • Unit and E2E pass

Related Issues

Please link any related issues or bug reports that this PR will address.

Oleksandr_Halichenko added 2 commits October 24, 2024 11:35
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
15.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@AlexGalichenko AlexGalichenko merged commit eaddc0c into v2 Oct 24, 2024
4 of 5 checks passed
@AlexGalichenko AlexGalichenko deleted the fix-unit-tests branch October 24, 2024 08:39
AlexGalichenko added a commit that referenced this pull request Dec 4, 2024
* reworked page object approach (#134)
* updated dependency to qavajs core (#136)
* removed utils (#137)
* fixed typings
* fixed unit test
* updated workflow to run tests on v2
* add page object e2e tests (#139)
* add memory processor to playwrightLocator parameter type (#140)

---------

Co-authored-by: Alexandr Legchilov <46843062+ALegchilov@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants