Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the application of Rayleigh correction above 0.8 micron on the Geo sats #2972

Merged

Conversation

adybbroe
Copy link
Contributor

@adybbroe adybbroe commented Nov 7, 2024

This PR removes the attempt to apply Rayleigh correction above 0.8 micron on the Geo sats, where it has no effect anyhow.

It also adds back the rayleigh correction at two places, both for the natual-color RGB on ABI and AHI, where it was commented out - don't know for what reason it was taken away? Maybe that needs clarification?

This PR is similar to #2970 - that did the same for VIIRS

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

Adam.Dybbroe added 2 commits November 7, 2024 14:01
…ould be applied above 0.8 micron

Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
@adybbroe
Copy link
Contributor Author

adybbroe commented Nov 7, 2024

Here the spectral responses for the three sats affected, for reference:

rsr_band_0070_0090

@adybbroe adybbroe self-assigned this Nov 7, 2024
@adybbroe
Copy link
Contributor Author

adybbroe commented Nov 7, 2024

@gerritholl and @pnuu You make imagery from both AHI and ABI right?
Do you use the nartual-color RGB? In case you do, is there a reason not to include the Rayleigh correction on the 0.6 micron channel? I guess the effect is really small, but to be consistent with how we do elsewhere I think it should also be corrected for the false-color RGB?

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.10%. Comparing base (573de5e) to head (4a8d8ff).
Report is 21 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2972   +/-   ##
=======================================
  Coverage   96.10%   96.10%           
=======================================
  Files         377      377           
  Lines       55134    55134           
=======================================
  Hits        52984    52984           
  Misses       2150     2150           
Flag Coverage Δ
behaviourtests 3.94% <ø> (ø)
unittests 96.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Nov 7, 2024

Pull Request Test Coverage Report for Build 11743751123

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on bugfix-rayleigh-corrections-geo-sats at 96.206%

Totals Coverage Status
Change from base Build 11723344367: 96.2%
Covered Lines: 53228
Relevant Lines: 55327

💛 - Coveralls

@gerritholl
Copy link
Collaborator

gerritholl commented Nov 7, 2024

@adybbroe We process ABI and AHI, but we produce only one RGB (airmass), so have no experience with Rayleigh correction for those sensors.

This would be a good case to test our image comparison tests! See https://github.com/pytroll/image-comparison-tests-dev/pull/2 and #2912

@mraspaud
Copy link
Member

mraspaud commented Nov 8, 2024

have we ever applied rayleigh correction to natural_colors?

@pnuu
Copy link
Member

pnuu commented Nov 8, 2024

have we ever applied rayleigh correction to natural_colors?

No, I don't think we have.

@adybbroe
Copy link
Contributor Author

adybbroe commented Nov 8, 2024

have we ever applied rayleigh correction to natural_colors?

I just saw that it was there but commented out. So, I suspect it was at some point?

@adybbroe
Copy link
Contributor Author

adybbroe commented Nov 8, 2024

Can it be for computational speed it is avoided (and the fact that it doesn't probably have a big positive/negative effect either or)?

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mraspaud mraspaud merged commit 0ca64e4 into pytroll:main Nov 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants