-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the application of Rayleigh correction above 0.8 micron on the Geo sats #2972
Remove the application of Rayleigh correction above 0.8 micron on the Geo sats #2972
Conversation
…ould be applied above 0.8 micron Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
@gerritholl and @pnuu You make imagery from both AHI and ABI right? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2972 +/- ##
=======================================
Coverage 96.10% 96.10%
=======================================
Files 377 377
Lines 55134 55134
=======================================
Hits 52984 52984
Misses 2150 2150
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 11743751123Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
@adybbroe We process ABI and AHI, but we produce only one RGB (airmass), so have no experience with Rayleigh correction for those sensors. This would be a good case to test our image comparison tests! See https://github.com/pytroll/image-comparison-tests-dev/pull/2 and #2912 |
have we ever applied rayleigh correction to natural_colors? |
No, I don't think we have. |
I just saw that it was there but commented out. So, I suspect it was at some point? |
Can it be for computational speed it is avoided (and the fact that it doesn't probably have a big positive/negative effect either or)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
This PR removes the attempt to apply Rayleigh correction above 0.8 micron on the Geo sats, where it has no effect anyhow.
It also adds back the rayleigh correction at two places, both for the natual-color RGB on ABI and AHI, where it was commented out - don't know for what reason it was taken away? Maybe that needs clarification?
This PR is similar to #2970 - that did the same for VIIRS
AUTHORS.md
if not there already