-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add image comparison behave tests #2912
base: main
Are you sure you want to change the base?
Conversation
The branch for this PR includes 322 MiB in data (8 PNG files), added in commit 1367072. We should probably upload those files somewhere (zenodo?) and then include code to download them on-the-fly, as to not pollute the git repository with large binary files. This may need rewriting the commit history? |
Yes, I think getting completely rid of the images from the repo requires rewriting the git history on force-pushing. |
If we remove the images in a dedicated commit, then squash the commits before merge, would that be enough to remove the images from the git history? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2912 +/- ##
==========================================
+ Coverage 95.97% 96.05% +0.07%
==========================================
Files 368 373 +5
Lines 53973 54406 +433
==========================================
+ Hits 51801 52259 +458
+ Misses 2172 2147 -25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 11075540122Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Pytroll image comparison dev behave tests as PR. This method of code transfer was proposed by Martin Raspaud.
Documentation for the behave tests will be provided with the rest of the project code.