Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to xr dataset merge error with conflicting values in coordinate #2827

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

fix: order of dataarrays

3da840d
Select commit
Loading
Failed to load commit list.
Open

Fix to xr dataset merge error with conflicting values in coordinate #2827

fix: order of dataarrays
3da840d
Select commit
Loading
Failed to load commit list.
codefactor.io / CodeFactor succeeded Jul 17, 2024 in 15s

44 issues fixed. 33 issues found.

Annotations

Check notice on line 1508 in satpy/composites/__init__.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

satpy/composites/__init__.py#L1508

Unresolved comment '# TODO: Turn this into a weighted RGB compositor'. (C100)

Check notice on line 414 in satpy/writers/awips_tiled.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

satpy/writers/awips_tiled.py#L414

Unresolved comment '# TODO: Return the slice instead of the actual data array'. (C100)

Check notice on line 1238 in satpy/writers/awips_tiled.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

satpy/writers/awips_tiled.py#L1238

Unresolved comment '# TODO: Allow for new variables to be created'. (C100)

Check notice on line 1510 in satpy/writers/awips_tiled.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

satpy/writers/awips_tiled.py#L1510

Unresolved comment '# TODO: Add additional untiled variable support'. (C100)

Check notice on line 1606 in satpy/writers/awips_tiled.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

satpy/writers/awips_tiled.py#L1606

Unresolved comment '# TODO: Create Dataset object of all of the sliced-DataArrays (optional)'. (C100)

Check notice on line 1615 in satpy/writers/awips_tiled.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

satpy/writers/awips_tiled.py#L1615

Unresolved comment '# TODO: Provide attribute caching for things that likely won't change (functools lrucache)'. (C100)

Check notice on line 737 in satpy/readers/yaml_reader.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

satpy/readers/yaml_reader.py#L737

Unresolved comment '# FIXME: areas could be concatenated here'. (C100)

Check notice on line 401 in satpy/resample.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

satpy/resample.py#L401

Unresolved comment '# FIXME: We need to move all of this caching logic to pyresample'. (C100)

Check notice on line 973 in satpy/resample.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

satpy/resample.py#L973

Unresolved comment '# TODO: move this to pyresample.resampler'. (C100)

Check notice on line 988 in satpy/resample.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

satpy/resample.py#L988

Unresolved comment '# TODO: move this to pyresample'. (C100)

Check notice on line 1021 in satpy/resample.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

satpy/resample.py#L1021

Unresolved comment '# TODO: move this to pyresample'. (C100)

Check notice on line 168 in satpy/tests/reader_tests/test_sar_c_safe.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

satpy/tests/reader_tests/test_sar_c_safe.py#L168

Multiple spaces after operator. (E222)

Check notice on line 634 in satpy/composites/viirs.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

satpy/composites/viirs.py#L634

Unresolved comment '# TODO: if the mask masks everything out this will be a zero!' (C100)

Check notice on line 704 in satpy/dataset/dataid.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

satpy/dataset/dataid.py#L704

Unresolved comment '# FIXME: this ought to be clarified, not sure that'. (C100)

Check notice on line 171 in satpy/readers/fci_l1c_nc.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

satpy/readers/fci_l1c_nc.py#L171

Unresolved comment '# FIXME: replace by .removesuffix after we drop support for Python < 3.9'. (C100)

Check notice on line 227 in satpy/readers/nwcsaf_nc.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

satpy/readers/nwcsaf_nc.py#L227

Unresolved comment '# TODO: do we really need to add units to everything ?' (C100)

Check notice on line 93 in satpy/readers/utils.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

satpy/readers/utils.py#L93

Unresolved comment '# TODO: take into account sweep_axis_angle parameter'. (C100)

Check notice on line 148 in satpy/readers/eps_l1b.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

satpy/readers/eps_l1b.py#L148

Multiple spaces after ':'. (E241)

Check notice on line 221 in satpy/readers/hrit_base.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

satpy/readers/hrit_base.py#L221

Unresolved comment '# FIXME: find a reasonable SSP'. (C100)

Check notice on line 286 in satpy/readers/netcdf_utils.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

satpy/readers/netcdf_utils.py#L286

Unresolved comment '# TODO: Handle HDF4 versus NetCDF3 versus NetCDF4'. (C100)

Check notice on line 167 in satpy/readers/seviri_l1b_nc.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

satpy/readers/seviri_l1b_nc.py#L167

Unresolved comment '# TODO: Move _add_scanline_acq_time() call to the end of the method'. (C100)

Check notice on line 352 in satpy/readers/seviri_l1b_nc.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

satpy/readers/seviri_l1b_nc.py#L352

Unresolved comment '# TODO: Enable once HRV reading has been fixed.' (C100)

Check notice on line 123 in satpy/readers/olci_nc.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

satpy/readers/olci_nc.py#L123

Unresolved comment '# TODO: get metadata from the manifest file (xfdumanifest.xml)'. (C100)

Check notice on line 383 in satpy/readers/olci_nc.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

satpy/readers/olci_nc.py#L383

Unresolved comment '# TODO: the following depends on more than columns, rows'. (C100)

Check notice on line 259 in satpy/readers/slstr_l1b.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

satpy/readers/slstr_l1b.py#L259

Unresolved comment '# TODO: get metadata from the manifest file (xfdumanifest.xml)'. (C100)