Fix to xr dataset merge error with conflicting values in coordinate #2827
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2827 +/- ##
==========================================
- Coverage 95.94% 95.91% -0.03%
==========================================
Files 366 366
Lines 53504 53519 +15
==========================================
+ Hits 51332 51335 +3
- Misses 2172 2184 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
satpy/scene.py
Outdated
| """Merge all xr.DataArrays of a scene to a xr.DataSet. | ||
|
|
||
| Parameters: | ||
| datasets (list): | ||
| List of products to include in the :class:`xarray.Dataset` | ||
| compat (Optional[str]): |
There was a problem hiding this comment.
The Optional type suggests this can be None, but that's not true is it?
There was a problem hiding this comment.
Hah I think you are right I always thought optional does not mean it can be None rather if you do not provide it the default arg is used. Then I need to change it. I guess if one uses optional you have to check for none inside the function and then set the default. I think that's a little overhead and not very nice but is in accordance with the documentation of Optional.
There was a problem hiding this comment.
Just make it "str" only and have the default be a string. No need for Optional or None checking.
|
The failing test output really doesn't help determine what is wrong/unequal for that test. |
Fixes the merge error Problem by allowing to pass the
compatargument.to_xarray_datasetfor Scenes containing data from seviri_l1b_nc reader #2179