Fix bug getting local tlefiles #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 21, 2023 16:51
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Codecov Report
@@ Coverage Diff @@
## main #129 +/- ##
==========================================
+ Coverage 87.51% 87.55% +0.03%
==========================================
Files 15 15
Lines 2211 2218 +7
==========================================
+ Hits 1935 1942 +7
Misses 276 276
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
added 2 commits
July 5, 2023 15:30
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
djhoese
reviewed
Jul 5, 2023
djhoese
reviewed
Jul 5, 2023
Co-authored-by: David Hoese <david.hoese@ssec.wisc.edu>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
…ed for Satpy Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
… into fix-bug-local-tlefile
djhoese
reviewed
Jul 6, 2023
djhoese
reviewed
Jul 6, 2023
|
looking at it now |
mraspaud
approved these changes
Jul 6, 2023
added 2 commits
July 6, 2023 18:02
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves a bug introduced when revising the TLES env variable recently. See #113 . There was a test for this, but it asserted the wrong thing, so test and code was wrong.
The error arise when specifying a local directory of tle-files via the
TLESenvironment variable. The_get_uris_and_open_funcfunction wrongly returned the directory path and not the full path of the latest TLE file in that directory.flake8 pyorbital