Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of env variables free from satpy #113

Merged

Conversation

adybbroe
Copy link
Contributor

@adybbroe adybbroe commented Nov 18, 2022

This PR tries to clean up a bit concerning the use of environment variables and tle file handling.
The old (mpop) legacy env variable PPP_CONFIG_DIR is removed. A new one is introduced instead: PYORBITAL_CONFIG_PATH. It is now also documented correctly and this also includes the use of the TLES environment which was not mentioned.

Adam.Dybbroe added 2 commits November 18, 2022 08:39
…emove test suites

Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #113 (5a0ca49) into main (5590f65) will increase coverage by 0.60%.
The diff coverage is 82.85%.

@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   87.04%   87.65%   +0.60%     
==========================================
  Files          13       15       +2     
  Lines        2054     2203     +149     
==========================================
+ Hits         1788     1931     +143     
- Misses        266      272       +6     
Flag Coverage Δ
unittests 87.65% <82.85%> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyorbital/check_platform.py 0.00% <0.00%> (ø)
pyorbital/logger.py 0.00% <0.00%> (ø)
pyorbital/tests/test_aiaa.py 100.00% <ø> (+4.76%) ⬆️
pyorbital/tests/test_astronomy.py 100.00% <ø> (+13.33%) ⬆️
pyorbital/tests/test_orbital.py 99.14% <ø> (+2.86%) ⬆️
pyorbital/tlefile.py 93.12% <91.66%> (+1.78%) ⬆️
pyorbital/tests/test_tlefile.py 99.75% <99.06%> (+1.74%) ⬆️
pyorbital/tests/test_geoloc.py 100.00% <100.00%> (+5.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

pyorbital/tlefile.py Outdated Show resolved Hide resolved
…es at version 1.7

Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
doc/source/index.rst Outdated Show resolved Hide resolved
Update doc/source/index.rst

Co-authored-by: David Hoese <david.hoese@ssec.wisc.edu>
doc/source/index.rst Outdated Show resolved Hide resolved
doc/source/index.rst Outdated Show resolved Hide resolved
adybbroe and others added 4 commits January 20, 2023 09:34
Co-authored-by: David Hoese <david.hoese@ssec.wisc.edu>
Co-authored-by: David Hoese <david.hoese@ssec.wisc.edu>
…nt var name

Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
@adybbroe adybbroe requested a review from djhoese January 20, 2023 11:00
Adam.Dybbroe added 2 commits January 20, 2023 16:25
… tests

Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
doc/source/index.rst Show resolved Hide resolved
doc/source/index.rst Outdated Show resolved Hide resolved
doc/source/index.rst Outdated Show resolved Hide resolved
doc/source/index.rst Outdated Show resolved Hide resolved
Adam.Dybbroe added 4 commits January 22, 2023 21:07
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
…tion how to check if a platform is supported on default.

Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
doc/source/index.rst Outdated Show resolved Hide resolved
doc/source/index.rst Show resolved Hide resolved
doc/source/index.rst Show resolved Hide resolved
bin/check_platform.py Outdated Show resolved Hide resolved
@adybbroe adybbroe mentioned this pull request Feb 15, 2023
3 tasks
@djhoese
Copy link
Member

djhoese commented Feb 16, 2023

FYI if you have other PRs you are planning you could drop Python 3.8 support and add 3.11 to the CI tests.

@djhoese djhoese merged commit eb15aaf into pytroll:main Feb 16, 2023
@adybbroe adybbroe mentioned this pull request Jun 21, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Is the TLES environment variable described?
3 participants