Revert S64 and U64 type change for Neuron device due to hardcoded dtype checks in torch-xla #8375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… checks in tensor_ops and index_ops
jeffhataws
approved these changes
Nov 12, 2024
JackCaoG
approved these changes
Nov 12, 2024
Contributor
Author
|
If the PR is approved, would it be possible to merge it soon so the previous change doesn't block anyone? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An earlier PR 8347 implemented downcasting for 64-bit ops for Neuron devices. However, due to few hardcoded dtype checks in torch-xla (in tensor_ops and index_ops), this change needs to be reverted to unblock compilation failure.
Since this change was only implemented for Neuron devices, it (or rather reverting it) would not have any impact on others.