XLA downcast for S64 and U64 for Neuron #8347
Merged
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpsilva-aws
reviewed
Oct 31, 2024
rpsilva-aws
reviewed
Oct 31, 2024
jeffhataws
approved these changes
Oct 31, 2024
rpsilva-aws
approved these changes
Oct 31, 2024
Collaborator
patrick-toulme
approved these changes
Nov 4, 2024
patrick-toulme
left a comment
patrick-toulme
left a comment
There was a problem hiding this comment.
LGTM. I am also tracking this on Jax side jax-ml/jax#24682
JackCaoG
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR downcasts the S64 and U64 datatypes for Neuron devices, to prevent unsupported datatypes from being lowered to the compiler.