Skip to content

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Jan 7, 2021

Although we migrated all remaining workflows from Travis CI to CIrcleCi in #3137 the status badge in the README was not upgraded:

This PR replaces this with

This is the default badge style from CircleCI, but we could also go with

for consistency.

@pmeier
Copy link
Collaborator Author

pmeier commented Jan 7, 2021

After some more research, it seems that the CircleCI badge is not reliable. Without knowing the internals, I imagine it does something like a logical OR instead of AND with the individual workflows.

There seem to be a lot of discussion about this in their support forums. As of now I think we should not place this badge since it might be misleading. @fmassa?

@pmeier
Copy link
Collaborator Author

pmeier commented Jan 8, 2021

I've contacted the CircleCI support about this. The badge only shows the status of the last run workflow which is on the top of the list in their UI, i.e. nightly. There is now a feature request for what we need. Until then we have only two options if we want the status badge:

  1. Determine the most important workflow and move it to run last.
  2. Merge all workflows into one.

IMO both options are subpar. Thus, I suggest we remove the badge for now and only re-add it if the feature request went through.

@pmeier pmeier requested a review from fmassa January 8, 2021 19:56
@pmeier pmeier changed the title upgrade status badge from Travis CI to CircleCI remove Travis CI status badge from README Jan 8, 2021
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmeier!

@fmassa
Copy link
Member

fmassa commented Jan 20, 2021

I agree with your current solution, we can add the CircleCI badge in the future

@fmassa fmassa merged commit 146dd85 into pytorch:master Jan 20, 2021
facebook-github-bot pushed a commit that referenced this pull request Feb 1, 2021
Summary:
* upgrade status badge from Travis CI to CircleCI

* remove CircleCI status badge

Reviewed By: datumbox

Differential Revision: D26156371

fbshipit-source-id: 87dcbf5d2aa7065b34fa230478dc79dd927db20f

Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
@pmeier pmeier deleted the update-ci-badge branch February 25, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants