Remove TravisCI #3137
Merged
Remove TravisCI #3137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add hub tests to CircleCI, coverage and ONNX are still missing
Codecov Report
@@ Coverage Diff @@
## master #3137 +/- ##
=======================================
Coverage 72.75% 72.75%
=======================================
Files 99 99
Lines 8979 8979
Branches 1431 1431
=======================================
Hits 6533 6533
Misses 1999 1999
Partials 447 447 Continue to review full report at Codecov.
|
datumbox
approved these changes
Dec 8, 2020
|
Interesting, looks like codecov is still running? Let's see if it will continue running after this PR get's merged |
fmassa
added a commit
to fmassa/vision-1
that referenced
this pull request
Dec 8, 2020
* Remove TravisCI Add hub tests to CircleCI, coverage and ONNX are still missing * Install torchvision dependencies on CI
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 8, 2020
Summary: * Remove TravisCI Add hub tests to CircleCI, coverage and ONNX are still missing * Install torchvision dependencies on CI Pull Request resolved: #3141 Reviewed By: datumbox Differential Revision: D25397167 Pulled By: fmassa fbshipit-source-id: 57e3de333176f0156afebc1a2be5e37a2bbca45c
|
Re-enabled test_onnx through the above PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
travis-ci.org is being removed in favour of travis-ci.com. We have moved all but the following tests to run on CircleCI already:
In here, I add hub tests to CircleCI and removed
.travis.ymlentirely.Code coverage and ONNX are still missing. Given that ONNX tests have been failing for more than a week now #3007, I'm temporarily removing ONNX from our testing, but they should be re-enabled back (in CircleCI).
video_reader will be added once #2818 gets merged.
I believe there is no need to test between PIL / PIL-simd, as PIL-simd is meant to be a drop-in replacement for PIL, so it might be enough to test PIL (but I'd love to hear your thoughts on this)
cc @spandantiwari @neginraoof for ONNX