Skip to content

Torchx: rename Application to AppDef #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

aivanou
Copy link
Contributor

@aivanou aivanou commented Jun 5, 2021

Summary: The diff renames Application to AppDef, only inside torchx, exposing it as Application in tsm dir for BC

Reviewed By: kiukchung

Differential Revision: D28853523

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Jun 5, 2021
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D28853523

Summary:
Pull Request resolved: pytorch/torchx#30

The diff renames Application to AppDef, only inside torchx, exposing it as Application in tsm dir for BC

Reviewed By: kiukchung

Differential Revision: D28853523

fbshipit-source-id: ec0e3b2ecd7e4c01ea684debdf6a1c188753517a
@aivanou aivanou force-pushed the export-D28853523 branch from 012f51a to 4935218 Compare June 5, 2021 22:02
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D28853523

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 9e71581.

facebook-github-bot pushed a commit to pytorch/elastic that referenced this pull request Jun 5, 2021
Summary:
Pull Request resolved: pytorch/torchx#30

The diff renames Application to AppDef, only inside torchx, exposing it as Application in tsm dir for BC

Reviewed By: kiukchung

Differential Revision: D28853523

fbshipit-source-id: a5869c49b1d38ef97c2beeb9374d142cf9364be5
@d4l3k d4l3k deleted the export-D28853523 branch June 7, 2021 20:59
fotstrt pushed a commit to eth-easl/elastic that referenced this pull request Feb 17, 2022
Summary:
Pull Request resolved: pytorch/torchx#30

The diff renames Application to AppDef, only inside torchx, exposing it as Application in tsm dir for BC

Reviewed By: kiukchung

Differential Revision: D28853523

fbshipit-source-id: a5869c49b1d38ef97c2beeb9374d142cf9364be5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants