Add support for https etcd access. #30
Conversation
|
I've verified this is working for me on my setup to access etcd with certs/key. |
| """ | ||
| import re | ||
| from urllib.parse import urlparse | ||
|
|
||
| url = urlparse(url) | ||
| assert url.scheme == "etcd" | ||
|
|
||
| kwargs = {} |
There was a problem hiding this comment.
can we move the declaration + initialization of kwargs = {} down to line 1169 so that it is closer where it is used? and also extract the kwargs parsing to a method (e.g. parse_etcd_client_params(params) -> Dict)
There was a problem hiding this comment.
awesome looks great! thanks! will merge to trunk.
There was a problem hiding this comment.
@kiukchung has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@kit1980 has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@kiukchung has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@kiukchung merged this pull request in 6721147. |
Summary: Pull Request resolved: pytorch/torchx#30 The diff renames Application to AppDef, only inside torchx, exposing it as Application in tsm dir for BC Reviewed By: kiukchung Differential Revision: D28853523 fbshipit-source-id: a5869c49b1d38ef97c2beeb9374d142cf9364be5
Summary: As discussed in pytorch#28 Pull Request resolved: pytorch#30 Differential Revision: D19398066 Pulled By: kiukchung fbshipit-source-id: 528f45519cb357efc02cc1e9b5774a9e395a70a8
Summary: Pull Request resolved: pytorch/torchx#30 The diff renames Application to AppDef, only inside torchx, exposing it as Application in tsm dir for BC Reviewed By: kiukchung Differential Revision: D28853523 fbshipit-source-id: a5869c49b1d38ef97c2beeb9374d142cf9364be5
As discussed in #28