Skip to content

Minor typo + Update install_requirements.sh to support python 3.10 >= #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Minor typo + Update install_requirements.sh to support python 3.10 >= #1368

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1335e09
Update install_requirements.sh to support python 3.10 >= , <3.13
Jack-Khuu Nov 12, 2024
803c41e
Update install_requirements.sh
Jack-Khuu Nov 13, 2024
988e8a5
Merge branch 'main' into Jack-Khuu-patch-25
Jack-Khuu Nov 13, 2024
a2917ea
Update install_requirements.sh
Jack-Khuu Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions install/install_requirements.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,21 @@ then
if [[ -z ${CONDA_DEFAULT_ENV:-} ]] || [[ ${CONDA_DEFAULT_ENV:-} == "base" ]] || [[ ! -x "$(command -v python)" ]];
then
PYTHON_EXECUTABLE=python3
else
PYTHON_EXECUTABLE=python
fi
fi
echo "Using python executable: $PYTHON_EXECUTABLE"

PYTHON_SYS_VERSION="$($PYTHON_EXECUTABLE -c "import sys; print(f'{sys.version_info.major}.{sys.version_info.minor}')")"
# Check python version. Expect 3.10.x or 3.11.x
# Check python version. Expect at least 3.10.x
if ! $PYTHON_EXECUTABLE -c "
import sys
if sys.version_info < (3, 10) or sys.version_info >= (3, 12):
if sys.version_info < (3, 10):
sys.exit(1)
";
then
echo "Python version must be 3.10.x or 3.11.x. Detected version: $PYTHON_SYS_VERSION"
echo "Python version must be at least 3.10.x. Detected version: $PYTHON_SYS_VERSION"
exit 1
fi

Expand Down
Loading