Minor typo + Update install_requirements.sh to support python 3.10 >= #1368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1368
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a2917ea with merge base 93f713f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
Going to use this PR to address some other related instrall_req bugs and open python to 3.10+ |
Jack-Khuu
changed the title
leseb
approved these changes
Nov 13, 2024
Gasoonjia
reviewed
Nov 13, 2024
install/install_requirements.sh
Outdated
| fi | ||
| fi | ||
| echo "Using python executable: $PYTHON_EXECUTABLE" | ||
|
|
||
| PYTHON_SYS_VERSION="$($PYTHON_EXECUTABLE -c "import sys; print(f'{sys.version_info.major}.{sys.version_info.minor}')")" | ||
| # Check python version. Expect 3.10.x or 3.11.x | ||
| # Check python version. Expect greater than 3.10.x |
There was a problem hiding this comment.
word and code below seem mismatch -- here we say greater than 3.10.x, but the code below is for greater than or equlal to 3.10
vmpuri
approved these changes
Nov 13, 2024
vmpuri
pushed a commit
that referenced
this pull request
Feb 4, 2025
…#1368) * Update install_requirements.sh to support python 3.10 >= , <3.13 * Update install_requirements.sh * Update install_requirements.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fixes to install_requirement (undefined variable) + Loosen the Python requirements to 3.10.0+
Fails with 3.8
Works with 3.10.0