Hydra integration #202
Merged
Hydra integration #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
# Conflicts: # .circleci/unittest/linux/scripts/environment.yml # .circleci/unittest/linux_stable/scripts/environment.yml
vmoens
added
enhancement
* Added TrainConfig dataclass to replace args * Added dataclass RecorderConfig for recorder.py * Added ReplayArgsConfig * Added comments for ReplayArgsConfig, TrainerConfig, and RecorderConfig * Added OffPolicyCollectorConfig and OnPolicyCollectorConfig dataclasses * Added EnvConfig * Added LossConfig and LossPPOConfig * Added ContinuousModelConfig and DiscreteModelConfig * Integrated hydra w/ ppo example * Able to override parameters w/ yaml file provided through command line * PPO example working w/ hydra * Fixed styling issues * Added hydra dependencies to setup.py * Refactored args from argparser to cfg * Fixed style issues * Fixing more style issues * Refactor input config file to overriding_cfg * Removed import of DictConfig, now using str type hinting for DictConfig * Integrated hydra into SAC * Make hydra optional dependency in trainers.py * change cfg comment * Removed hydra in trainers.py * Changing hydra-core version to >=1.1 version * Modified tests affected by hydra change * Fixing style issues in trainers.py * Added hydra dependency to environment.yml * Added generate_seeds import Co-authored-by: Bhuvan Basireddy <bbreddy@devfair0832.h2.fair>
* Added TrainConfig dataclass to replace args * Added dataclass RecorderConfig for recorder.py * Added ReplayArgsConfig * Added comments for ReplayArgsConfig, TrainerConfig, and RecorderConfig * Added OffPolicyCollectorConfig and OnPolicyCollectorConfig dataclasses * Added EnvConfig * Added LossConfig and LossPPOConfig * Added ContinuousModelConfig and DiscreteModelConfig * Integrated hydra w/ ppo example * Able to override parameters w/ yaml file provided through command line * PPO example working w/ hydra * Fixed styling issues * Added hydra dependencies to setup.py * Refactored args from argparser to cfg * Fixed style issues * Fixing more style issues * Refactor input config file to overriding_cfg * Removed import of DictConfig, now using str type hinting for DictConfig * Integrated hydra into SAC * Integrated hydra into DDPG * Make hydra optional dependency in trainers.py * change cfg comment * Removed hydra in trainers.py * Changing hydra-core version to >=1.1 version * Modified tests affected by hydra change * Fixing style issues in trainers.py * Added hydra dependency to environment.yml * Added generate_seeds import Co-authored-by: Bhuvan Basireddy <bbreddy@devfair0832.h2.fair>
* Added TrainConfig dataclass to replace args * Added dataclass RecorderConfig for recorder.py * Added ReplayArgsConfig * Added comments for ReplayArgsConfig, TrainerConfig, and RecorderConfig * Added OffPolicyCollectorConfig and OnPolicyCollectorConfig dataclasses * Added EnvConfig * Added LossConfig and LossPPOConfig * Added ContinuousModelConfig and DiscreteModelConfig * Integrated hydra w/ ppo example * Able to override parameters w/ yaml file provided through command line * PPO example working w/ hydra * Fixed styling issues * Added hydra dependencies to setup.py * Refactored args from argparser to cfg * Fixed style issues * Fixing more style issues * Refactor input config file to overriding_cfg * Removed import of DictConfig, now using str type hinting for DictConfig * Integrated hydra into SAC * Integrated hydra into DDPG * Integrated hydra into REDQ * Make hydra optional dependency in trainers.py * change cfg comment * Removed hydra in trainers.py * Changing hydra-core version to >=1.1 version * Modified tests affected by hydra change * Fixing style issues in trainers.py * Added hydra dependency to environment.yml * Added generate_seeds import * Changes working Co-authored-by: Bhuvan Basireddy <bbreddy@devfair0832.h2.fair>
# Conflicts: # examples/ddpg/ddpg.py # examples/dqn/dqn.py # examples/ppo/ppo.py # examples/redq/redq.py # examples/sac/sac.py # torchrl/trainers/helpers/envs.py # torchrl/trainers/helpers/recorder.py # torchrl/trainers/helpers/replay_buffer.py # torchrl/trainers/helpers/trainers.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.