Skip to content

Integrating hydra with SAC #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Jun 16, 2022
Merged

Integrating hydra with SAC #198

merged 30 commits into from
Jun 16, 2022

Conversation

BoboBananas
Copy link
Contributor

Integrated hydra with SAC using structured configs.
Checked by validating hydra version of SAC gives similar results as the original version.

Bhuvan Basireddy and others added 29 commits June 9, 2022 10:44
Added TrainConfig dataclass to replace args
f0432f5
Added dataclass RecorderConfig for recorder.py
c67ea95
Added ReplayArgsConfig
6a29d09
Added comments for ReplayArgsConfig, TrainerConfig, and RecorderConfig
c784e3c
Added OffPolicyCollectorConfig and OnPolicyCollectorConfig dataclasses
00b11a0
Added EnvConfig
60a2ed2
Added LossConfig and LossPPOConfig
c5a174e
Added ContinuousModelConfig and DiscreteModelConfig
eab1650
Integrated hydra w/ ppo example
6d5d28f
Able to override parameters w/ yaml file provided through command line
ac4ffc9
PPO example working w/ hydra
8b87b3a
Fixed styling issues
23a4d66
Added hydra dependencies to setup.py
062ade0
Refactored args from argparser to cfg
93d2869
Fixed style issues
eeb3c81
Fixing more style issues
0fa9d4f
Refactor input config file to overriding_cfg
05b650c
Removed import of DictConfig, now using str type hinting for DictConfig
c78c495
Integrated hydra into SAC
9bfacd4
Make hydra optional dependency in trainers.py
3e4a58a
change cfg comment
5da617b
Removed hydra in trainers.py
8094add
Changing hydra-core version to >=1.1 version
f986e2d
Modified tests affected by hydra change
71e96ec
@BoboBananas
Merge branch 'hydra_integration' into hydra_dev_ppo
d51f6f0
Fixing style issues in trainers.py
00cf44f
Added hydra dependency to environment.yml
069a0cf
Added generate_seeds import
f9156ad
Merging changes from ppo branch
a0cedff
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 15, 2022
@vmoens vmoens added the enhancement New feature or request label Jun 16, 2022
vmoens
vmoens approved these changes Jun 16, 2022
View reviewed changes
Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@vmoens vmoens merged commit 47066f0 into pytorch:hydra_integration Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BoboBananas @vmoens @facebook-github-bot