-
Notifications
You must be signed in to change notification settings - Fork 350
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
coverage via coveralls in CircleCI (#515)
Summary: ## Types of changes - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Docs change / refactoring / dependency upgrade (None of the above - changes are made to CI pipeline) ## Motivation and Context / Related issue The objective was to have code coverage made [publicly accessible](#424) via https://coveralls.io To achieve this, the following changes were made: 1. move existing tests running via `pytest` & `unittest` to run via [`coverage`](https://coverage.readthedocs.io) 2. add dependency of `coverage` in `dev_requirements.txt`, followed by `coveralls` in CircleCI config 3. minor refactoring of tasks to prepare for upload to `coveralls` 4. upload coverage reports generated in `parallel` to `coveralls` as CircleCI tasks 5. at the end of workflow, signal `coveralls` to combine all `parallel` uploads under single run ## How Has This Been Tested (if it applies) Testing changes made to CircleCI config is tricky. Most of the code was tested via opening this PR and letting CircleCI run on this new config. Some obscure parts were tested in a personal CircleCI environment. ## Checklist - [ ] The documentation is up-to-date with the changes I made. - [x] I have read the **CONTRIBUTING** document and completed the CLA (see **CONTRIBUTING**). - [x] All tests passed, and additional code has been covered with new tests. Pull Request resolved: #515 Reviewed By: ashkan-software Differential Revision: D39795415 Pulled By: ashkan-software fbshipit-source-id: 82830bfea917bed7efcb15d854f7e1af34802dbb
- Loading branch information
1 parent
5e632cd
commit a6c2567
Showing
3 changed files
with
55 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters