Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage via coveralls in CircleCI #515

Closed
wants to merge 3 commits into from
Closed

Conversation

arn7av
Copy link
Contributor

@arn7av arn7av commented Sep 24, 2022

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs change / refactoring / dependency upgrade

(None of the above - changes are made to CI pipeline)

Motivation and Context / Related issue

The objective was to have code coverage made publicly accessible via https://coveralls.io
To achieve this, the following changes were made:

  1. move existing tests running via pytest & unittest to run via coverage
  2. add dependency of coverage in dev_requirements.txt, followed by coveralls in CircleCI config
  3. minor refactoring of tasks to prepare for upload to coveralls
  4. upload coverage reports generated in parallel to coveralls as CircleCI tasks
  5. at the end of workflow, signal coveralls to combine all parallel uploads under single run

How Has This Been Tested (if it applies)

Testing changes made to CircleCI config is tricky. Most of the code was tested via opening this PR and letting CircleCI run on this new config. Some obscure parts were tested in a personal CircleCI environment.

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 24, 2022
@ashkan-software
Copy link
Contributor

Thanks for working on this. Let me know when you are done :)

@arn7av arn7av marked this pull request as ready for review September 26, 2022 21:55
@facebook-github-bot
Copy link
Contributor

@arn7av has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@arn7av has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@arn7av has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@arn7av arn7av deleted the arn7av_add_coverage_coveralls branch September 29, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants