Skip to content

Conversation

KickItLikeShika
Copy link
Contributor

Fixes #2126

Moved time_profilers from contrib to core.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added docs module: contrib Contrib module module: handlers Core Handlers module labels Aug 2, 2021
@KickItLikeShika KickItLikeShika changed the title Move handlers to core Moved BasicTimeProfiler and HandlersTimeProfiler to core Aug 2, 2021
@sdesrozis
Copy link
Contributor

@KickItLikeShika thank you ! Did you take care of keeping the git history of the file time_profilers.py ? (I mean using git mv or mv command ?)

@KickItLikeShika
Copy link
Contributor Author

@sdesrozis thanks for asking! Yes I did, I always follow this approach https://stackoverflow.com/questions/1043388/record-file-copy-operation-with-git/46484848#46484848, as you can see in the 3 first commits

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Aug 3, 2021

@KickItLikeShika thank you ! Did you take care of keeping the git history of the file time_profilers.py ? (I mean using git mv or mv command ?)

@sdesrozis this is a good question. I think we didn't do that for previous classes neither.

@KickItLikeShika
Copy link
Contributor Author

KickItLikeShika commented Aug 3, 2021

@vfdev-5 I did the same thing while moving LRFinder to core #1998 (comment)

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Aug 3, 2021

@vfdev-5 I did the same thing while moving LRFinder to core #1998 (comment)

Maybe, but there is no git history for the file : https://github.com/pytorch/ignite/commits/3ef85e1b7af58cfbcf2033d62085a759aa722cc1/ignite/handlers/lr_finder.py . It appears as a new file.

@KickItLikeShika
Copy link
Contributor Author

@vfdev-5 We can try git mv directly but the file in the contrib will have no history, what do you think?

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Aug 3, 2021

@vfdev-5 We can try git mv directly but the file in the contrib will have no history, what do you think?

@sdesrozis thoughts ? I think we can continue as it is right now as other files already do not have any history.

@sdesrozis
Copy link
Contributor

We have the full git history, so there is no issue here. Let's continue as we did before.

@KickItLikeShika KickItLikeShika requested a review from vfdev-5 August 4, 2021 09:36
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vfdev-5 vfdev-5 enabled auto-merge (squash) August 4, 2021 12:36
@vfdev-5 vfdev-5 merged commit 155e173 into pytorch:master Aug 4, 2021
@KickItLikeShika KickItLikeShika deleted the move-handlers-to-core branch August 4, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs module: contrib Contrib module module: handlers Core Handlers module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move BasicTimeProfiler and HandlersTimeProfiler from contrib to core
3 participants