-
-
Notifications
You must be signed in to change notification settings - Fork 654
Moved BasicTimeProfiler
and HandlersTimeProfiler
to core
#2132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved BasicTimeProfiler
and HandlersTimeProfiler
to core
#2132
Conversation
BasicTimeProfiler
and HandlersTimeProfiler
to core
@KickItLikeShika thank you ! Did you take care of keeping the git history of the file |
@sdesrozis thanks for asking! Yes I did, I always follow this approach https://stackoverflow.com/questions/1043388/record-file-copy-operation-with-git/46484848#46484848, as you can see in the 3 first commits |
…handlers-to-core
@sdesrozis this is a good question. I think we didn't do that for previous classes neither. |
@vfdev-5 I did the same thing while moving LRFinder to core #1998 (comment) |
Maybe, but there is no git history for the file : https://github.com/pytorch/ignite/commits/3ef85e1b7af58cfbcf2033d62085a759aa722cc1/ignite/handlers/lr_finder.py . It appears as a new file. |
@vfdev-5 We can try |
@sdesrozis thoughts ? I think we can continue as it is right now as other files already do not have any history. |
We have the full git history, so there is no issue here. Let's continue as we did before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #2126
Moved
time_profilers
from contrib to core.Check list: