Skip to content

Move LRFinder to core #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 15, 2021
Merged

Move LRFinder to core #1998

merged 8 commits into from
May 15, 2021
+499 −480

Conversation

KickItLikeShika
Copy link
Contributor

@KickItLikeShika KickItLikeShika commented May 14, 2021 •
edited
Loading

Moving LRFinder to core.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added docs examples Examples module: handlers Core Handlers module labels May 14, 2021
@vfdev-5 vfdev-5 requested a review from fco-dv May 14, 2021 15:19
@sdesrozis
Copy link
Contributor

sdesrozis commented May 15, 2021 •
edited
Loading

@KickItLikeShika Thank you for the PR.

Have a look to param_scheduler.py which has recently been moved from contrib to handlers.

https://github.com/pytorch/ignite/blob/ee2c7eeb8d07b56366868054b513f14e868f4d2e/ignite/contrib/handlers/param_scheduler.py

You need to first use the command git copy to duplicate the file and keep the history of commits. Secondly you have to depreciate the file using the same strategy than in param_scheduler.py.

Could you update the PR following these comments ? Thank you !

@vfdev-5 vfdev-5 requested a review from sdesrozis May 15, 2021 11:45
sdesrozis
sdesrozis approved these changes May 15, 2021
View reviewed changes
Copy link
Contributor

@sdesrozis sdesrozis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KickItLikeShika Thanks a lot ! LGTM !

@vfdev-5 vfdev-5 merged commit e89666a into pytorch:master May 15, 2021
@KickItLikeShika KickItLikeShika deleted the move-lrfinder-to-core branch May 15, 2021 13:00
@vfdev-5 vfdev-5 mentioned this pull request Jul 28, 2021
Closed
This was referenced Aug 3, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fco-dv fco-dv Awaiting requested review from fco-dv

1 more reviewer

@sdesrozis sdesrozis sdesrozis approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
docs examples Examples module: handlers Core Handlers module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KickItLikeShika @sdesrozis @vfdev-5