Run setup-macos.sh in unittest-macos even in Buck mode #9505
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9505
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 2 Cancelled JobsAs of commit 47e81fc with merge base d16b867 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
swolchok
added a commit
that referenced
this pull request
Mar 21, 2025
We've been seeing flakes due to missing torchgen that have become more common. After some investigation, it appears that #8688 was probably overzealous: installing pytorch was probably also installing torchgen, so let's install pytorch. Test Plan: unittest-buck / macos on this PR, monitor to see if failures go away. ghstack-source-id: 05496b1 ghstack-comment-id: 2744469219 Pull Request resolved: #9505
facebook-github-bot
added
the
CLA Signed
swolchok
added a commit
that referenced
this pull request
Mar 21, 2025
We've been seeing flakes due to missing torchgen that have become more common. After some investigation, it appears that #8688 was probably overzealous: installing pytorch was probably also installing torchgen, so let's install pytorch. Test Plan: unittest-buck / macos on this PR, monitor to see if failures go away. ghstack-source-id: 24a48bf ghstack-comment-id: 2744469219 Pull Request resolved: #9505
swolchok
changed the title
|
feel free to merge when accepting this PR |
GregoryComer
approved these changes
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been seeing flakes due to missing torchgen that have become more common. After some investigation, it appears that #8688 was probably overzealous: installing pytorch was probably also installing torchgen, so let's
install pytorchjust run the macos setup script to avoid proliferating configurations.Test Plan: unittest-buck / macos on this PR, monitor to see if failures go away.