Depend on extension/threadpool, not thread_parallel_interface, in buck #9511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
swolchok
requested review from
JacobSzwejbka,
lucylq,
manuelcandales and
kimishpatel
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9511
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit a405ce1 with merge base 90f0843 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
swolchok
added a commit
that referenced
this pull request
Mar 21, 2025
I planned to do this everywhere and forgot. Clean it all up, leave a note, enforce the note with visibility. This makes sure everything in buck-land gets ET_USE_THREADPOOL. Test Plan: Profiled run on internal model, no longer seeing parallel_for_no_threadpool ghstack-source-id: e371f0b ghstack-comment-id: 2744624045 Pull Request resolved: #9511
facebook-github-bot
added
the
CLA Signed
|
unittest-buck / macos is having problems on main. (#9505 is out to fix them.) I ran unittest-buck2.sh locally on mac and verified it passed. |
swolchok
added a commit
that referenced
this pull request
Mar 24, 2025
I planned to do this everywhere and forgot. Clean it all up, leave a note, enforce the note with visibility. This makes sure everything in buck-land gets ET_USE_THREADPOOL. Test Plan: Profiled run on internal model, no longer seeing parallel_for_no_threadpool ghstack-source-id: 4495656 ghstack-comment-id: 2744624045 Pull Request resolved: #9511
|
ping reviewers @JacobSzwejbka @manuelcandales @kimishpatel @lucylq |
manuelcandales
approved these changes
Mar 26, 2025
swolchok
added a commit
that referenced
this pull request
Mar 27, 2025
swolchok
added a commit
that referenced
this pull request
Mar 27, 2025
swolchok
pushed a commit
that referenced
this pull request
Apr 3, 2025
…e, in buck (#9511)" Trying again with internal fixes. Original summary: I planned to do this everywhere and forgot. Clean it all up, leave a note, enforce the note with visibility. This makes sure everything in buck-land gets ET_USE_THREADPOOL. Differential Revision: [D72090889](https://our.internmc.facebook.com/intern/diff/D72090889/) [ghstack-poisoned]
swolchok
pushed a commit
that referenced
this pull request
Apr 3, 2025
…e, in buck (#9511)" Trying again with internal fixes. Original summary: I planned to do this everywhere and forgot. Clean it all up, leave a note, enforce the note with visibility. This makes sure everything in buck-land gets ET_USE_THREADPOOL. Differential Revision: [D72090889](https://our.internmc.facebook.com/intern/diff/D72090889/) ghstack-source-id: 276012372 Pull Request resolved: #9890
swolchok
pushed a commit
that referenced
this pull request
Apr 3, 2025
…adpool, not thread_parallel_interface, in buck (#9511)"" Trying again with internal fixes. Original summary: I planned to do this everywhere and forgot. Clean it all up, leave a note, enforce the note with visibility. This makes sure everything in buck-land gets ET_USE_THREADPOOL. Differential Revision: [D72090889](https://our.internmc.facebook.com/intern/diff/D72090889/) [ghstack-poisoned]
swolchok
pushed a commit
that referenced
this pull request
Apr 3, 2025
…e, in buck (#9511)" Pull Request resolved: #9890 Trying again with internal fixes. Original summary: I planned to do this everywhere and forgot. Clean it all up, leave a note, enforce the note with visibility. This makes sure everything in buck-land gets ET_USE_THREADPOOL. Differential Revision: [D72090889](https://our.internmc.facebook.com/intern/diff/D72090889/) ghstack-source-id: 276017129
swolchok
pushed a commit
that referenced
this pull request
Apr 5, 2025
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
#9511) I planned to do this everywhere and forgot. Clean it all up, leave a note, enforce the note with visibility. This makes sure everything in buck-land gets ET_USE_THREADPOOL. Test Plan: Profiled run on internal model, no longer seeing parallel_for_no_threadpool
kirklandsign
added a commit
that referenced
this pull request
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I planned to do this everywhere and forgot. Clean it all up, leave a note, enforce the note with visibility. This makes sure everything in buck-land gets ET_USE_THREADPOOL.
Test Plan: Profiled run on internal model, no longer seeing parallel_for_no_threadpool