-
Notifications
You must be signed in to change notification settings - Fork 584
determine fht_avx.c/fht_neon.c based on CMake target processor #8346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8346
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 8df2f1d with merge base f3fc096 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
773ff37
to
d4aaa36
Compare
# Second clause is to pick up fht_neon.c/fht_avx.c from FFHT. TODO: | ||
# remove filters and patch extract_sources.py's Buck query to fetch | ||
# srcs; presumably filters is here to remove .h files. | ||
"(.cpp$)|(fht.*\\.c$)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comment is irrelevant since you are removing it, but this second regex seemed wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks right to me. Dot is a regex metacharacter so we need to escape it with a backslash. Backslash is a string metacharacter so we need to escape it with a second backslash. Or is there a different problem I missed entirely?
Might fix #6691.